Open
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #5
This commit implements the changes requested in issue #5 to use associated types instead of generic parameters for the Doublets trait. Changes made: - Updated Links trait: `Links<T>` -> `Links` with `type Item: LinkType` - Updated Doublets trait: `Doublets<T>` -> `Doublets` (inherits Item from Links) - Updated DoubletsExt trait: `DoubletsExt<T>` -> `DoubletsExt` - Updated all implementations of these traits in Store and Unit Store - Updated decorator structs to use associated types - Updated all usage sites across the codebase and tests - Updated FFI bindings to use new syntax This makes the API more idiomatic as suggested, allowing usage like: - `struct Wrapper<D: Doublets>` instead of `struct Wrapper<T, D: Doublets<T>>` - The type `T` is now accessible as `D::Item` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the changes requested in issue #5 to use associated types instead of generic parameters for the Doublets trait, making the API more idiomatic.
Changes Made
Links<T: LinkType>→Linkswithtype Item: LinkTypeDoublets<T: LinkType>: Links<T>→Doublets: Links(inherits Item from Links)DoubletsExt<T: LinkType>: Sized + Doublets<T>→DoubletsExt: Sized + DoubletsBenefits
This change enables cleaner, more idiomatic code as shown in the issue example:
Before:
After:
Compatibility
This is a breaking change that affects:
Links,Doublets, andDoubletsExttraitsTest plan
Fixes #5
🤖 Generated with Claude Code