Rework ffi with new `logging`, `error handling` and some improvements in arch and safe by uselessgoddess · Pull Request #10 · linksplatform/doublets-rs

uselessgoddess · 2022-08-14T12:05:27Z

No description provided.

uselessgoddess · 2022-08-16T17:13:28Z

It also may solve #2 issue

doublets-ffi/examples/rust/examples/doublets-context.rs

- use more debug logs - use more high-level types - fix useless code in ffi bindings - add function to work with error data (incomplete) - improve `doublets`, `platform-data` to make it compatible with new changes

uselessgoddess

I did a little review

uselessgoddess · 2022-08-18T15:59:24Z

doublets-ffi/examples/rust/examples/all-logs.rs

+        tracing::error!("SOMETHING IS SERIOUSLY WRONG!!!");
+        tracing::warn!("important informational messages; might indicate an error");
+        tracing::info!("general informational messages relevant to users");
+        tracing::debug!("diagnostics used for internal debugging of a library or application");
+        tracing::trace!("very verbose diagnostic events");


Move logs out unsafe context. It's confusing

uselessgoddess · 2022-08-18T15:59:56Z

doublets-ffi/examples/rust/examples/doublets-context.rs

+    unsafe {
+        let handler = &mut *(ctx as *mut F);
+        (*handler)(before, after);
+        Flow::Continue
+    }


unsafe context is too long

Suggested change

unsafe {

let handler = &mut *(ctx as *mut F);

(*handler)(before, after);

Flow::Continue

}

let handler = unsafe { &mut *(ctx as *mut F) };

(*handler)(before, after);

Flow::Continue

uselessgoddess · 2022-08-18T16:00:47Z

doublets-ffi/examples/rust/examples/doublets-context.rs

+unsafe fn magic_create<F>(ptr: *mut c_void, handler: F)
+where
+    F: FnMut(Link<u64>, Link<u64>),
+{
+    let ctx = &mut (ptr, handler);
+    let _ = create(ptr, null(), 0, ctx as *mut _ as *mut _, create_cb::<F>);
+}


We could supplement this example almost to the level of real use

uselessgoddess · 2022-08-18T16:01:20Z

doublets-ffi/examples/rust/examples/doublets-context.rs

+        let path = CString::new("doublets.links").unwrap();
+        let mut store = doublets_create_united_store_u64(
+            path.as_ptr(),
+            Constants::from(LinksConstants::external()),


Add ffi functions to create external/internal constants

uselessgoddess · 2022-08-18T16:03:47Z

doublets-ffi/examples/rust/examples/log-context.rs

+    if *ctx % 2 == 0 {
+        print!("{str}");
+    } else {
+        eprint!("{str}");
+    }


The difference between print and eprint is not noticeable. Use something more different

More panic!

Bro, panic abort my example :(

doublets-ffi/src/store.rs

uselessgoddess · 2022-08-18T16:25:41Z

doublets-ffi/src/store.rs

+
+fn place_error<T: LinkType>(err: Error<T>) {
+    // It can be very expensive to handle each error
+    debug!(op_error = % err);


op_error? Think of something better

doublets-ffi/src/store.rs

- Fix forgotten `each` in moder style - Rename `DoubletsErrorKind` to `DoubletsResultKind` (it must contain `Continue`/`Break`) - improve error handling for create store (and fix example)

- use modern syntax: ```rust #[ffi::specialize_for( types( u8 => "u8", u16 => "uint16", u32 => "uint", u64 => "ll", ), name = "...*", )] ``` - add warnings handler - use more beautiful code

…plementation - fix ffi build

add `.gitignore` with `.cargo`

- `Fallible<T, E>` can't drop without generics (can impl manually dropping by C++)

Remove ffi with new logging and some improvements in arch and safe

7333525

uselessgoddess changed the title ~~Remove ffi with new logging and some improvements in arch and safe~~ Rework ffi with new logging and some improvements in arch and safe Aug 14, 2022

uselessgoddess requested review from FreePhoenix888, Mitron57, flakeed and konard August 14, 2022 12:29

uselessgoddess added 3 commits August 14, 2022 17:46

Improve logging (via instruments) and naming

4d59bae

Add ffi context to callbacks

e0edd83

Add ffi examples crate

e8691c2

uselessgoddess mentioned this pull request Aug 16, 2022

Wrap all exported functions to catch and unwind #2

Open

uselessgoddess added 2 commits August 17, 2022 17:46

Fix too long ptr cast

63be554

Improve safety docs

b1a3d77

Mitron57 reviewed Aug 18, 2022

View reviewed changes

doublets-ffi/examples/rust/examples/doublets-context.rs Outdated Show resolved Hide resolved

Improve error handling:

f4c7cb4

- use more debug logs - use more high-level types - fix useless code in ffi bindings - add function to work with error data (incomplete) - improve `doublets`, `platform-data` to make it compatible with new changes

uselessgoddess changed the title ~~Rework ffi with new logging and some improvements in arch and safe~~ Rework ffi with new logging, error handling and some improvements in arch and safe Aug 18, 2022

uselessgoddess commented Aug 18, 2022

View reviewed changes

uselessgoddess added 13 commits August 19, 2022 15:48

Use thread_local attribute for ERROR_PLACE

a40e21e

Improve warn message in query_from_raw

7dd3cd9

Improvements list:

4600061

- Fix forgotten `each` in moder style - Rename `DoubletsErrorKind` to `DoubletsResultKind` (it must contain `Continue`/`Break`) - improve error handling for create store (and fix example)

Improvements list:

4f6b95b

- Fix forgotten `each` in moder style - Rename `DoubletsErrorKind` to `DoubletsResultKind` (it must contain `Continue`/`Break`) - improve error handling for create store (and fix example)

Update outdated data

a11188f

Use NonNull instead of raw pointer

edd0b87

cargo fix unused imports

646f1ae

cargo fix unused imports

6d7c353

Improve ffi-attributes:

abee06b

- use modern syntax: ```rust #[ffi::specialize_for( types( u8 => "u8", u16 => "uint16", u32 => "uint", u64 => "ll", ), name = "...*", )] ``` - add warnings handler - use more beautiful code

Remove forgotten comment

8420a12

Fix type lit => ty

4ec685a

Add attributes keyword to delegate some attrs to parent function im…

6c71760

…plementation - fix ffi build

Fix some externs

cc2eee1

uselessgoddess added 30 commits September 4, 2022 14:59

Start queries reworking

3338ba8

Merge remote-tracking branch 'origin/ffi-rework' into ffi-rework

78cf083

Revert queries reworking

97c2640

Forbid dynamic lib to ffi

918d255

Add docs to FFICallbackContextWrapper

26927a7

Improve Range and add Maybe to simplify constants conversion

8561b07

Fix typo

903d07e

Improve backtrace feature in favor of unstable_backtrace

ae182b5

add `.gitignore` with `.cargo`

Fix if-else-let lint

3eb54ef

Add marker<Box<[T]>> to OwnedSlice

d6de95a

allow(clippy::borrowed_box) for assume_ref

c2a4813

Use while let instead of loop { if let } in logging loop

766df15

Use slice as queries

2e7e592

Add error handling to store creation

155f475

explain if let to .is_ok

d619560

Use shortest error messages

af3fef0

Shortest ptr cast

722094c

Improve error handling in favor of Rust looks like

8da33d5

Fix priv utils mod

3bf0a7e

Disable clippy with bug

0e71c0e

Fix fallible example

8433376

Really disable clippy

a5156ed

Use shortest names

a95d580

Improve code for future readers

fb70b9c

Improve code for future readers - two-step

9042ce8

Add cbindgen config for cxx (but with problems):

3754990

- `Fallible<T, E>` can't drop without generics (can impl manually dropping by C++)

Cosmetic improvements

3b272d9

Remove unused imports

fb2aad6

Improve Fallible messages and idioms

ce9449a

Remove type - useless import

97e12b2

Conversation

uselessgoddess commented Aug 14, 2022

Uh oh!

uselessgoddess commented Aug 16, 2022

Uh oh!

Uh oh!

uselessgoddess left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants