Skip to content

Fix Count logic bug in C# and C++ implementations #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Count logic bug in C# and C++ implementations #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97dd5b4
Initial commit with task details for issue #359
konard Sep 11, 2025
00a7118
Remove CLAUDE.md - PR created successfully
konard Sep 11, 2025
fa8ed49
Fix Count logic bug in C# and C++ implementations
konard Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions cpp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,18 +315,19 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
}
return LinkAddressType{0};
}
auto value = LinkAddressType{};
if ((source == any))
{
value = target;
if ((storedLinkValue.Target == target))
{
return LinkAddressType{1};
}
}
if ((target == any))
{
value = source;
}
if ((storedLinkValue.Source == value) || (storedLinkValue.Target == value))
{
return LinkAddressType{1};
if ((storedLinkValue.Source == source))
{
return LinkAddressType{1};
}
}
return LinkAddressType{0};
}
Expand Down Expand Up @@ -528,18 +529,19 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
}
return LinkAddressType{0};
}
auto value = LinkAddressType{0};
if ((source == any))
{
value = target;
if ((storedLinkValue.Target == target))
{
return LinkAddressType{1};
}
}
if ((target == any))
{
value = source;
}
if ((storedLinkValue.Source == value) || (storedLinkValue.Target == value))
{
return LinkAddressType{1};
if ((storedLinkValue.Source == source))
{
return LinkAddressType{1};
}
}
return LinkAddressType{0};
}
Expand Down Expand Up @@ -724,18 +726,19 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
}
return $continue;
}
auto value = LinkAddressType{0};
if (source == any)
{
value = target;
if ((storedLinkValue.Target == target))
{
return handler(GetLinkStruct(index));
}
}
if (target == any)
{
value = source;
}
if ((storedLinkValue.Source == value) || (storedLinkValue.Target == value))
{
return handler(GetLinkStruct(index));
if ((storedLinkValue.Source == source))
{
return handler(GetLinkStruct(index));
}
}
return $continue;
}
Expand Down
15 changes: 8 additions & 7 deletions csharp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,18 +390,19 @@ public virtual TLinkAddress Count(IList<TLinkAddress>? restriction)
}
return GetZero();
}
var value = default(TLinkAddress);
if ((source == any))
{
value = target;
if ((storedLinkValue.Target == target))
{
return GetOne();
}
}
if ((target == any))
{
value = source;
}
if ((storedLinkValue.Source == value) || (storedLinkValue.Target == value))
{
return GetOne();
if ((storedLinkValue.Source == source))
{
return GetOne();
}
}
return GetZero();
}
Expand Down
88 changes: 88 additions & 0 deletions examples/count_logic_test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
using System;
using System.Collections.Generic;

namespace Platform.Data.Doublets.Examples
{
/// <summary>
/// Test case to verify the Count logic fix for issue #359
/// This demonstrates the corrected behavior where source==any or target==any
/// should be handled separately rather than with variable overwriting
/// </summary>
public class CountLogicTest
{
public class MockStoredLinkValue
{
public ulong Source { get; set; }
public ulong Target { get; set; }
}

private const ulong any = 0; // Assuming 0 represents "any"

/// <summary>
/// Old (buggy) logic that had the issue
/// </summary>
public static bool OldBuggyLogic(MockStoredLinkValue storedLinkValue, ulong source, ulong target)
{
var value = default(ulong);
if (source == any)
{
value = target;
}
if (target == any) // This overwrites value even if source was any!
{
value = source;
}
return (storedLinkValue.Source == value) || (storedLinkValue.Target == value);
}

/// <summary>
/// New (fixed) logic that handles each case separately
/// </summary>
public static bool NewFixedLogic(MockStoredLinkValue storedLinkValue, ulong source, ulong target)
{
if (source == any)
{
if (storedLinkValue.Target == target)
{
return true;
}
}
if (target == any)
{
if (storedLinkValue.Source == source)
{
return true;
}
}
return false;
}

public static void RunTests()
{
var testLink = new MockStoredLinkValue { Source = 1, Target = 2 };

// Test case 1: source=any, target=2 (should match target)
Console.WriteLine("Test 1: source=any, target=2, stored=(1,2)");
Console.WriteLine($"Old logic: {OldBuggyLogic(testLink, any, 2)}");
Console.WriteLine($"New logic: {NewFixedLogic(testLink, any, 2)}");
Console.WriteLine();

// Test case 2: source=1, target=any (should match source)
Console.WriteLine("Test 2: source=1, target=any, stored=(1,2)");
Console.WriteLine($"Old logic: {OldBuggyLogic(testLink, 1, any)}");
Console.WriteLine($"New logic: {NewFixedLogic(testLink, 1, any)}");
Console.WriteLine();

// Test case 3: source=any, target=any (edge case, neither should match in this context)
Console.WriteLine("Test 3: source=any, target=any, stored=(1,2)");
Console.WriteLine($"Old logic: {OldBuggyLogic(testLink, any, any)}");
Console.WriteLine($"New logic: {NewFixedLogic(testLink, any, any)}");
Console.WriteLine();

// Test case 4: source=1, target=3 (no match expected)
Console.WriteLine("Test 4: source=1, target=3, stored=(1,2)");
Console.WriteLine($"Old logic: {OldBuggyLogic(testLink, 1, 3)}");
Console.WriteLine($"New logic: {NewFixedLogic(testLink, 1, 3)}");
}
}
}
Loading