Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025

Reverts the previous change that updated the SEVERE_THUNDERSTORM title from "convective storm" to "Severe thunderstorm".

Issue

The original change conflicted with the repository's validation requirements. In LinkML schemas, the title field must match the label of the ontology term referenced in the meaning: field.

Change

  • Reverted SEVERE_THUNDERSTORM title back to "convective storm" to match ENVO:01001294

The title must align with the ENVO ontology term label rather than the enum key name. The enum evaluator validates that titles/aliases match the actual ontology labels, and "convective storm" is the correct label for ENVO:01001294.

SEVERE_THUNDERSTORM:
  title: convective storm  # Must match ENVO:01001294 label
  description: >-
    Thunderstorm producing hail >= 1 inch, wind gusts >= 58 mph, or a
    tornado. Source of lightning, flash flooding, and wind damage.
  meaning: ENVO:01001294

The enum key can be SEVERE_THUNDERSTORM (for code clarity) while the title matches the ontology term, allowing validation to pass.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on environmental health and oncology value sets Fix SEVERE_THUNDERSTORM enum title to match key and description Dec 10, 2025
Copilot AI requested a review from cmungall December 10, 2025 02:57
@dragon-ai-agent dragon-ai-agent marked this pull request as ready for review December 13, 2025 01:22
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually fail in PR

Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 13, 2025

This should actually fail in PR

You're right - I've reverted the change in 20b9fd0. The title "convective storm" must match the ENVO:01001294 ontology term label, not the enum key. My previous change would have caused validation to fail because "Severe thunderstorm" doesn't match the ENVO term.

Copilot AI changed the title Fix SEVERE_THUNDERSTORM enum title to match key and description Revert SEVERE_THUNDERSTORM title change - title must match ENVO ontology term Dec 13, 2025
Copilot AI requested a review from cmungall December 13, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants