-
Notifications
You must be signed in to change notification settings - Fork 6
Skip recursive map_object for scalars with no range #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+95
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| """Regression test: scalar slots with no explicit range should not emit warnings. | ||
|
|
||
| When a source slot has no range (and no default_range), _map_value_by_range | ||
| should short-circuit for scalar and multivalued scalar values instead of | ||
| falling through to map_object, which would log "Unexpected: <value>" warnings. | ||
|
|
||
| See: https://github.com/linkml/linkml-map/pull/173 | ||
| """ | ||
|
|
||
| import textwrap | ||
|
|
||
| from linkml_runtime import SchemaView | ||
|
|
||
| from linkml_map.transformer.object_transformer import ObjectTransformer | ||
|
|
||
| SOURCE_SCHEMA = textwrap.dedent("""\ | ||
| id: https://example.org/source | ||
| name: source | ||
| prefixes: | ||
| linkml: https://w3id.org/linkml/ | ||
| imports: | ||
| - linkml:types | ||
|
|
||
| classes: | ||
| Record: | ||
| attributes: | ||
| id: | ||
| identifier: true | ||
| tag: {} | ||
| tags: | ||
| multivalued: true | ||
| """) | ||
|
|
||
| TARGET_SCHEMA = textwrap.dedent("""\ | ||
| id: https://example.org/target | ||
| name: target | ||
| prefixes: | ||
| linkml: https://w3id.org/linkml/ | ||
| imports: | ||
| - linkml:types | ||
|
|
||
| classes: | ||
| Output: | ||
| attributes: | ||
| id: {} | ||
| tag: {} | ||
| tags: | ||
| multivalued: true | ||
| """) | ||
|
|
||
|
|
||
| def _make_transformer() -> ObjectTransformer: | ||
| """Build a transformer with schemas that have slots without explicit ranges.""" | ||
| transform = { | ||
| "source_schema": "https://example.org/source", | ||
| "target_schema": "https://example.org/target", | ||
| "class_derivations": { | ||
| "Output": { | ||
| "populated_from": "Record", | ||
| "slot_derivations": { | ||
| "id": {"populated_from": "id"}, | ||
| "tag": {"populated_from": "tag"}, | ||
| "tags": {"populated_from": "tags"}, | ||
| }, | ||
| } | ||
| }, | ||
| } | ||
| tr = ObjectTransformer() | ||
| tr.source_schemaview = SchemaView(SOURCE_SCHEMA) | ||
| tr.target_schemaview = SchemaView(TARGET_SCHEMA) | ||
| tr.create_transformer_specification(transform) | ||
| return tr | ||
|
|
||
|
|
||
| def test_scalar_no_range_no_warning(caplog): | ||
| """Mapping a scalar slot with no range should not emit an 'Unexpected' warning.""" | ||
| tr = _make_transformer() | ||
| result = tr.map_object({"id": "r1", "tag": "important"}, "Record") | ||
|
|
||
| assert result["tag"] == "important" | ||
| assert "Unexpected" not in caplog.text | ||
|
|
||
|
|
||
| def test_multivalued_scalar_no_range_no_warning(caplog): | ||
| """Mapping a multivalued scalar slot with no range should not emit an 'Unexpected' warning.""" | ||
| tr = _make_transformer() | ||
| result = tr.map_object({"id": "r1", "tags": ["a", "b", "c"]}, "Record") | ||
|
|
||
| assert result["tags"] == ["a", "b", "c"] | ||
| assert "Unexpected" not in caplog.text |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.