Add NMDC Biosample-Study cross-table join tests (#136)#148
Merged
amc-corey-cox merged 3 commits intomainfrom Mar 10, 2026
Merged
Add NMDC Biosample-Study cross-table join tests (#136)#148amc-corey-cox merged 3 commits intomainfrom
amc-corey-cox merged 3 commits intomainfrom
Conversation
Two integration tests for the joins: feature: - Biosample rows enriched with Study metadata via join on associated_studies (matched joins, orphan with null propagation) - Field preservation: all biosample-native fields pass through unchanged when joins are active Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds NMDC-specific integration coverage for the spec-driven joins: cross-table lookup feature by validating Biosample → Study denormalization behavior, including null propagation for missing joined rows.
Changes:
- Introduces an integration test that enriches Biosample rows with Study metadata via
joins:onassociated_studies, including orphan handling (null propagation). - Adds a second integration test ensuring biosample-native fields are preserved unchanged when joins are active.
Update docstring to reference the cross-table join feature rather than the now-merged branch name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joins:feature landed in PR Add cross-table lookup support for join-based transformations #136associated_studiesTest plan
main(post-Add cross-table lookup support for join-based transformations #136 merge)🤖 Generated with Claude Code