fix: use sass-embedded in local setup#2122
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Problem The local setup docs and build hint still point contributors at plain sass. That is easy to hit in practice, and with the current Hugo Dart Sass path it can make a local linkerd.io build fail. Solution Update the local setup instructions and the Makefile hint to recommend sass-embedded, which matches the working local build path. Fixes linkerd#2121 Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh local setup still points people at plain
sass, but that can break the Hugo build withTOCSS-DART ... got unexpected EOF when executing "sass". Pretty easy to hit.Fix
Point the README and Makefile hint to
sass-embedded, which makes the same build pass.Repro
tmp=$(mktemp -d) && cd "$tmp"npm init -y >/dev/null 2>&1 && npm install --save-dev sass >/dev/null 2>&1PATH="$tmp/node_modules/.bin:$PATH" hugo -s /path/to/website/linkerd.io --minify --cleanDestinationDirTOCSS-DARTerror