Update trust anchor rotation instructions #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflynn
requested changes
Dec 16, 2025
Member
kflynn
left a comment
kflynn
left a comment
There was a problem hiding this comment.
Looks really good. I left a few small nits (which should be copied to all the other versions), but mostly it's just embarrassing that I approved the version with the mistakes. 🙁
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
linkerd.io/content/2-edge/tasks/automatically-rotating-control-plane-tls-credentials.md
Outdated
Show resolved
Hide resolved
Member
|
I forced DCO because @fragglehunter is a Buoyant employee. |
Signed-off-by: Phil Henderson <philhenderson410@gmail.com>
Signed-off-by: Phil Henderson <philhenderson410@gmail.com>
Signed-off-by: Phil Henderson <philhenderson410@gmail.com>
Signed-off-by: Phil Henderson <philhenderson410@gmail.com>
fragglehunter
force-pushed
the
cert-manager-update
branch
from
f42e053 to
7a585a3
Compare
Signed-off-by: Phil Henderson <philhenderson410@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the cert-manager task with proper trust anchor rotation instructions. Changed inspect_cert function to be able to read bundles