fix(policy): Remove Appropriate AuthN Policy#15326
Open
raykroeker wants to merge 7 commits into
Open
Conversation
* Delete from the appropriate policy map when handling delete and reset calls. * Mark state as changed when removing items. * Continue with the removal iteration (vs return) in the network authn reset. * Fix copy and paste strings. * Add some test cases.
adleong
reviewed
May 28, 2026
|
|
||
| if let Entry::Occupied(mut ns) = self.authentications.by_ns.entry(ns) { | ||
| tracing::debug!("Deleting MeshTLSAuthentication"); | ||
| tracing::debug!("Deleting NetworkTLSAuthentication"); |
Member
There was a problem hiding this comment.
I think this should be NetworkAuthentication not NetworkTLSAuthentication
… into raykroeker/policy-inbound-authn
Contributor
Author
|
@adleong Sorry for extra merge commits. Thanks for the catch on the text error, should be ready for another pass. |
adleong
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raymond Kroeker raymond@buoyant.io