fix(destination): Add namespace restriction to external workloads and endpoints#15324
Open
raykroeker wants to merge 7 commits into
Open
fix(destination): Add namespace restriction to external workloads and endpoints#15324raykroeker wants to merge 7 commits into
raykroeker wants to merge 7 commits into
Conversation
* On MacOS the command snippet to collect 5 random characters for a test id intermettently fails with 'tr: Illegal byte sequence' due to binary output and charactersets. Use the builtin function [choose](https://just.systems/man/en/built-in-functions.html#random) to grab 5 random hex chars.
* Add a third external workload to the test case for external workload selection. It resides in another namespace and should not come back. This specific commit fails with: ```bash /Users/rkroeker/Code/linkerd/linkerd2/controller/api/destination/external-workload/endpoints_controller_test.go:260: Expected 1 endpoint in first slice, got: 2 ```
* When synchronizing, filter both external workloads as well as endpoints by namespace.
adleong
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raymond Kroeker raymond@buoyant.io