Allow ReadAllLimit inputs at byte limit#15301
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReadAllLimit was off by one: a body exactly at the configured cap returned
limit reached. This can hit normal HTTP paths with 1MiB/10MiB/100MiB caps; no special infra magic needed, an exact-size request or response body does it.Repro
Before this patch:
go test ./pkg/util -run TestReadAllLimit -count=1fails on
Allows input at limitwithlimit reached while reading: 5.Fix
Read one byte past the cap, so exactly-cap bytes are ok and cap+1 still fails. tiny off-by-one cleanup, imo.
Validation