refactor(CLI): Make check command more modular#15293
Open
adleong wants to merge 5 commits into
Open
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
alpeb
reviewed
May 21, 2026
| CliVersionOverride string | ||
| } | ||
|
|
||
| var CheckOptions *checkOptions |
Member
There was a problem hiding this comment.
What do you think about making the checkOptions struct public, instead of introducing this public var? The newCmdCheck() function would need to become public as well, and refactored to receive a pointer to that struct, instantiated by the caller. Similar to what was done with NewCmdInject() to provide more flexibility there.
Member
Author
There was a problem hiding this comment.
unfortunately, making newCmdCheck public wouldn't be sufficient for adding new checks to the Healthchecker because the cmd that newCmdCheck returns always uses the same list of checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We slightly refactor the
linkerd checkcommand into more modular and reusable pieces. In particular, we split theconfigureAndRunChecksfunction into two pieces:ConfigureChecksandRunChecks, making both of them public. This allows them to be invoked individually and to potentially modify theHealthCheckerin between.To further support that use-case, we add a
InsertCategoriesBeforefunction to theHealthCheckerthat allows inserting checks at particular locations in the order rather than only being able to append them to the end.