fix: set observedGeneration in HTTPRoute status#15069
Closed
themavik wants to merge 1 commit into
Closed
Conversation
Root cause: Controller never set observedGeneration in HTTPRoute status, leaving it at 0. This caused Flagger to block canary rollouts because it expects observedGeneration to match metadata.generation. Made-with: Cursor
themavik
commented
Mar 19, 2026
Author
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the fix is minimal and targeted. Good contribution.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14964.
Root cause: The controller never set
observedGenerationin HTTPRoute status, leaving it at 0. This caused Flagger to block canary rollouts because it expectsobservedGenerationto matchmetadata.generationper the Gateway API spec.Fix: Added
observedGenerationto the HTTPRoute status update, setting it tometadata.generation.Changes
Testing
Made with Cursor