fix: Synthetic proxy responses should contain an identifying header #14835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Synthetic proxy responses (responses generated by the control plane components rather than forwarded from upstream services) need an identifying header so clients can distinguish them from application responses. Solution: Add a Via header (RFC 7230) with value "1.1 linkerd" to all synthetic HTTP responses generated by the Linkerd control plane: - Admin server (/ping, /ready endpoints) - Web dashboard server - Reverse proxy responses (Grafana, Jaeger) - Proto HTTP responses (error and protobuf responses) The Via header is a standard HTTP header that identifies intermediate protocols and recipients between the user agent and the server. Fixes linkerd#2295 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Member
|
Hi @majiayu000 The issue you linked to refers to synthetic responses generated by the Linkerd proxy. This would need to be implemented in the Linkerd proxy, not the Linkerd control plane as you have done here. |
Author
|
@adleong Thanks for your review. I will close this pr and try to solve it in proxy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2295
Changes
pkg/admin/admin.gopkg/protohttp/protohttp.gopkg/protohttp/protohttp_test.goweb/srv/reverse_proxy.goweb/srv/server.go