chore(dns): update hickory-resolver from 0.25 to 0.26#4544
Draft
cratelyn wants to merge 2 commits into
Draft
Conversation
Member
cratelyn
commented
May 29, 2026
cratelyn
commented
- chore: bump hickory-resolver from 0.25 to 0.26
- chore(dns): address breaking changes
Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/update-hickory-to-0.26
branch
from
4d607ae to
f016653
Compare
Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/update-hickory-to-0.26
branch
from
f016653 to
54746e3
Compare
cratelyn
commented
May 29, 2026
Comment on lines
157
to
169
| let srv = self.dns.srv_lookup(name.as_str()).await?; | ||
|
|
||
| let valid_until = Instant::from_std(srv.as_lookup().valid_until()); | ||
| let valid_until = Instant::from_std(srv.valid_until()); | ||
| let addrs = srv | ||
| .into_iter() | ||
| .answers() | ||
| .iter() | ||
| .map(|record| &record.data) | ||
| .filter_map(|rdata| match rdata { | ||
| hickory_resolver::proto::rr::RData::SRV(srv) => Some(srv), | ||
| _ => None, | ||
| }) | ||
| .map(Self::srv_to_socket_addr) | ||
| .collect::<Result<_, InvalidSrv>>()?; |
Member
Author
There was a problem hiding this comment.
i've asked in hickory-dns/hickory-dns#3632 (comment) to confirm if this is equivalent. this is the part of this upgrade that i'm most nervous about being equivalent.
cratelyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.