fix: reject invalid traceparent flags#4538
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
W3C v00
traceparenthastrace-flags = 2 HEXDIGLC. The parser accepted...-0102, and...-could hitdecoded[0]after decoding an empty string. Tiny parser footgun.This checks the flags length before decode and adds regression cases.
Repro
Before this patch, add the new invalid flag cases and run:
cargo test -p linkerd-trace-context propagation::w3c::tests::w3c_context_invalid_flags -- --nocaptureIt fails because
...-0102is accepted. The empty flags case is also a real incoming HTTP header shape, no weird infra limit needed.Validation
cargo fmt --checkcargo test -p linkerd-trace-contextcargo clippy -p linkerd-trace-context --all-targets -- -D warnings