Skip to content

[common]: Add logging to setEnableWrites to track PUSHED to ONLINE version transitions#2434

Merged
misyel merged 3 commits intolinkedin:mainfrom
misyel:deferred-swap-logging
Feb 3, 2026
Merged

[common]: Add logging to setEnableWrites to track PUSHED to ONLINE version transitions#2434
misyel merged 3 commits intolinkedin:mainfrom
misyel:deferred-swap-logging

Conversation

@misyel
Copy link
Copy Markdown
Contributor

@misyel misyel commented Jan 30, 2026

Problem Statement

When investigating deferred version swap issues, it's difficult to determine when and why a version's status changed from PUSHED to ONLINE in non-target regions. The setEnableWrites(true) method in ZKStore has a side effect that calls setPushedVersionsOnline(), which converts ALL PUSHED versions to ONLINE status. Without logging, it's impossible to trace when this occurs.

Solution

Added INFO level logging to ZKStore.java:

  • Log when setEnableWrites(true) is called, including the store name
  • Log each version that gets changed from PUSHED to ONLINE in setPushedVersionsOnline(), including version number and store name

New log messages:

setEnableWrites(true) called for store {storeName}. Will check for PUSHED versions to mark ONLINE.
setPushedVersionsOnline: Changing version {versionNumber} of store {storeName} from {status} to ONLINE.

Code changes

  • Added new code behind a config.
  • Introduced new log lines.

Concurrency-Specific Checks

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms are used where needed.
  • No blocking calls inside critical sections.
  • Verified thread-safe collections are used.
  • Validated proper exception handling in multi-threaded code.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Existing tests pass. This is a logging-only change with no behavioral modifications.

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.

majisourav99
majisourav99 previously approved these changes Jan 30, 2026
misyel and others added 2 commits February 2, 2026 11:35
…rsion transitions

Add INFO logging to ZKStore.setEnableWrites() and setPushedVersionsOnline()
to help debug issues where versions unexpectedly change from PUSHED to ONLINE
status. This is particularly useful for investigating deferred version swap
issues where non-target regions may have versions incorrectly marked as ONLINE.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@misyel misyel force-pushed the deferred-swap-logging branch from 3ef8c56 to fff7bb8 Compare February 2, 2026 19:37
@misyel misyel merged commit 9f25179 into linkedin:main Feb 3, 2026
56 of 150 checks passed
sushantmane pushed a commit to sushantmane/venice that referenced this pull request Feb 8, 2026
misyel added a commit to misyel/venice that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants