[common]: Add logging to setEnableWrites to track PUSHED to ONLINE version transitions#2434
Merged
misyel merged 3 commits intolinkedin:mainfrom Feb 3, 2026
Merged
Conversation
majisourav99
previously approved these changes
Jan 30, 2026
31a21ac to
3ef8c56
Compare
…rsion transitions Add INFO logging to ZKStore.setEnableWrites() and setPushedVersionsOnline() to help debug issues where versions unexpectedly change from PUSHED to ONLINE status. This is particularly useful for investigating deferred version swap issues where non-target regions may have versions incorrectly marked as ONLINE. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3ef8c56 to
fff7bb8
Compare
mynameborat
approved these changes
Feb 3, 2026
sushantmane
pushed a commit
to sushantmane/venice
that referenced
this pull request
Feb 8, 2026
…rsion transitions (linkedin#2434)
misyel
added a commit
to misyel/venice
that referenced
this pull request
Feb 17, 2026
…rsion transitions (linkedin#2434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
When investigating deferred version swap issues, it's difficult to determine when and why a version's status changed from PUSHED to ONLINE in non-target regions. The
setEnableWrites(true)method inZKStorehas a side effect that callssetPushedVersionsOnline(), which converts ALL PUSHED versions to ONLINE status. Without logging, it's impossible to trace when this occurs.Solution
Added INFO level logging to
ZKStore.java:setEnableWrites(true)is called, including the store namesetPushedVersionsOnline(), including version number and store nameNew log messages:
Code changes
Concurrency-Specific Checks
How was this PR tested?
Existing tests pass. This is a logging-only change with no behavioral modifications.
Does this PR introduce any user-facing or breaking changes?