[server] send request to netty channel to cancel ongoing blob transfer#2430
Closed
jingy-li wants to merge 6 commits intolinkedin:mainfrom
Closed
[server] send request to netty channel to cancel ongoing blob transfer#2430jingy-li wants to merge 6 commits intolinkedin:mainfrom
jingy-li wants to merge 6 commits intolinkedin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Previously, blob transfer completion was handled asynchronously using .whenComplete() for all use cases. This could cause race conditions in server mode where a partition UNSUBSCRIBE request might arrive
before the SUBSCRIBE operation is queued, leading to inconsistent state.
Solution
dropStoragePartitionGracefully waiting for blobTransferManager.cancelTransfer complete before actual drop.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?