Skip to content

[server] send request to netty channel to cancel ongoing blob transfer#2430

Closed
jingy-li wants to merge 6 commits intolinkedin:mainfrom
jingy-li:add-stop-for-blob-transfer
Closed

[server] send request to netty channel to cancel ongoing blob transfer#2430
jingy-li wants to merge 6 commits intolinkedin:mainfrom
jingy-li:add-stop-for-blob-transfer

Conversation

@jingy-li
Copy link
Copy Markdown
Contributor

Problem Statement

Previously, blob transfer completion was handled asynchronously using .whenComplete() for all use cases. This could cause race conditions in server mode where a partition UNSUBSCRIBE request might arrive
before the SUBSCRIBE operation is queued, leading to inconsistent state.

Solution

dropStoragePartitionGracefully waiting for blobTransferManager.cancelTransfer complete before actual drop.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

@jingy-li jingy-li requested a review from sixpluszero January 29, 2026 18:29
@jingy-li jingy-li closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant