Move default cache root from ~/.shiv to ~/.cache/shiv#242
Open
TomiBelan wants to merge 1 commit intolinkedin:mainfrom
Open
Move default cache root from ~/.shiv to ~/.cache/shiv#242TomiBelan wants to merge 1 commit intolinkedin:mainfrom
TomiBelan wants to merge 1 commit intolinkedin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More precisely:
Motivation:
Implementation:
This is an ad hoc, informally-specified, bug-ridden, slow implementation of 1% of platformdirs. platformdirs is the most common library for this, for example it is used by pip to locate its own cache (~/.cache/pip). I didn't want to use platformdirs directly because this code is embedded into .pyz files and shouldn't have any dependencies. The main differences from the original platformdirs algorithm are that Windows only checks getenv (not ctypes/windll or registry) (see also), Windows falls back to Unix if getenv fails, and Android is not special cased (see also).
Please test!!:
I don't have a Windows or macOS development setup. I'd be grateful if someone could check that it works, and that the directory is created nearby to pip's cache (probably %LOCALAPPDATA%\pip\cache, ~/Library/Caches/pip).