Conversation
hshi2022
force-pushed
the
improve_log_20250625
branch
from
c3cef0b to
13753bb
Compare
CCisGG
reviewed
Jul 8, 2025
CCisGG
approved these changes
Jul 8, 2025
CCisGG
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for "[LIKAFKA-65517] Improve the Kafka broker controlled shutdown".
If a topic has replication factor (RF) that is smaller than (
minIsr+controlledShutdownSafetyCheckRedundancyFactor+ 1), the controlled shutdown would be stuck due to error NOT_ENOUGH_REPLICAS. e.g., a topic with RF=3 and minISR=2 with controlledShutdownSafetyCheckRedundancyFactor=1 , it would cause broker stuck in controlled shutdown.This PR auto updates RF to be at least (
minIsr+controlledShutdownSafetyCheckRedundancyFactor+ 1) during topic creation if replica assigments are not provided; if replica assignments are provided, it would throw error (topic creation will be failed) if the replica set size is smaller than (minIsr+controlledShutdownSafetyCheckRedundancyFactor+ 1). Also updated log level from "info" to "warn" if controlled shutdown could not proceed due to NOT_ENOUGH_REPLICAS.Added unittests and fixed breaking unittests due to this change.