Fix RCE vulnerability in JMH Benchmarks workflow#232
Open
vikrambohra wants to merge 1 commit intolinkedin:openhouse-1.2.0from
Open
Fix RCE vulnerability in JMH Benchmarks workflow#232vikrambohra wants to merge 1 commit intolinkedin:openhouse-1.2.0from
vikrambohra wants to merge 1 commit intolinkedin:openhouse-1.2.0from
Conversation
Move user-controlled workflow_dispatch inputs from direct shell interpolation to environment variables to prevent command injection. GitHub Actions sanitizes inputs when accessed through env vars, blocking shell metacharacter execution. Fixes: BDP-72545, PWN-46510 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchinputs from direct${{ }}shell interpolation toenv:variables, which GitHub automatically sanitizes against command injectionUser-controlled inputs (
spark_version,benchmarks,repo,ref) were directly interpolated into shellruncommands, allowing arbitrary command injection (e.g.,iceberg-spark-3.3| id; cat /etc/passwd;#).Fixes: BDP-72545, PWN-46510
Testing Done