Skip to content

Update task status on ZK if acquire was successful to reset previous state #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akshayrai merged 1 commit into from
Nov 3, 2025
Merged

Update task status on ZK if acquire was successful to reset previous state #990

akshayrai merged 1 commit into from
Nov 3, 2025

Conversation

@akshayrai
Copy link
Collaborator

@akshayrai akshayrai commented Nov 3, 2025

Summary

  • We have observed that Task status on Zookeeper doesn't get updated after cluster restarts and sometimes retains the old failure state which can be misleading. This PR addresses this by updating the task status whenever the lock acquire is successful.

Testing Done

  • PR checks only

kanishkjaiswal2015
kanishkjaiswal2015 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@kanishkjaiswal2015 kanishkjaiswal2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mittalprince
mittalprince approved these changes Nov 3, 2025
View reviewed changes
Copy link

@mittalprince mittalprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshayrai akshayrai merged commit 0670ac2 into linkedin:master Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanishkjaiswal2015 kanishkjaiswal2015 kanishkjaiswal2015 approved these changes

@khandelwal-ayush khandelwal-ayush khandelwal-ayush approved these changes

+1 more reviewer

@mittalprince mittalprince mittalprince approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akshayrai @mittalprince @kanishkjaiswal2015 @khandelwal-ayush