Skip to content

Conversation

@harshcum
Copy link
Collaborator

@harshcum harshcum commented Jul 17, 2025

Problem & Solution Overview

This PR introduces a new method getUndecoratedTopic() to extract the undecorated topic from the DatastreamRecordMetadata. This method was needed to address an issue where the SLA latency metrics were not being reported correctly due to the presence of topic decorations.

Previously, when extracting the topic name from the metadata, any decorations were included, causing issues with accurate SLA latency reporting. The new method ensures that only the undecorated topic name is used for reporting metrics related to SLA latency, leading to more accurate metrics for throughput and SLA violations.

Changes

  • Added getUndecoratedTopic() method: This method extracts the undecorated topic name from the metadata.
  • Modified SLA reporting logic: The latency metrics are now correctly reported by using the undecorated topic name.
    This was implemented in the onSendCallback() method where metrics for topics violating the SLA throughput are now based on the undecorated topic name.

Testing

  • Validated that the SLA reporting logic now uses the undecorated topic name and calculates the latency metrics correctly.

akshayrai
akshayrai previously approved these changes Sep 12, 2025
Copy link
Collaborator

@kanishkjaiswal2015 kanishkjaiswal2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshcum harshcum dismissed stale reviews from akshayrai and kanishkjaiswal2015 via 40e790c October 10, 2025 09:12
@harshcum harshcum merged commit 3076293 into master Oct 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants