Add Method to Extract Undecorated Topic from Datastream Metadata for Accurate SLA Latency Reporting #984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem & Solution Overview
This PR introduces a new method getUndecoratedTopic() to extract the undecorated topic from the DatastreamRecordMetadata. This method was needed to address an issue where the SLA latency metrics were not being reported correctly due to the presence of topic decorations.
Previously, when extracting the topic name from the metadata, any decorations were included, causing issues with accurate SLA latency reporting. The new method ensures that only the undecorated topic name is used for reporting metrics related to SLA latency, leading to more accurate metrics for throughput and SLA violations.
Changes
getUndecoratedTopic()method: This method extracts the undecorated topic name from the metadata.This was implemented in the
onSendCallback()method where metrics for topics violating the SLA throughput are now based on the undecorated topic name.Testing