Небольшой рефактор кода#25
Open
VavilovAlex wants to merge 8 commits intolink1107:masterfrom
Open
Conversation
VavilovAlex
commented
Feb 9, 2022
VavilovAlex
commented
- Заменил все string в циклах на StringBuilder так как для изменения строки приходиться ее каждый раз пересоздавать и это очень затратная операция
- Вместо !(object == null) можно писать object != null
- И легче использовать лямбды, а не new Emmiter.Listener()
И убрал лишний cast из Sender в Player
!= вместо !(==) И более компактный switch
link1107
force-pushed
the
master
branch
10 times, most recently
from
e4079e4 to
8e4a78e
Compare
Author
|
Ты лучше merge пулл реквесты чтобы они попадали в закрытые |
VladimirCreator
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.