Skip to content

fix: test start-screen for --dry-run mode for solve and hive commands (issue #539)#1430

Open
konard wants to merge 2 commits intomainfrom
issue-539-ff6d7f33ccd8
Open

fix: test start-screen for --dry-run mode for solve and hive commands (issue #539)#1430
konard wants to merge 2 commits intomainfrom
issue-539-ff6d7f33ccd8

Conversation

@konard
Copy link
Copy Markdown
Contributor

@konard konard commented Mar 14, 2026

Summary

Fixes #539

Problem

start-screen hive "https://github.com/konard" --dry-run --once --verbose was failing with "Invalid GitHub URL: missing owner/repo" because start-screen.mjs was not using the same URL validation logic as the hive and solve commands.

Root Cause

The original start-screen.mjs had its own URL validation that required both owner and repo, rejecting valid user/organization URLs like https://github.com/konard.

Fix

Accepted URL types

  • ✅ User URLs: https://github.com/owner
  • ✅ Repository URLs: https://github.com/owner/repo
  • ✅ Issue URLs: https://github.com/owner/repo/issues/123
  • ✅ Pull Request URLs: https://github.com/owner/repo/pull/456

Tests

All tests pass locally:

Testing --dry-run mode for solve command...
  solve --dry-run: ✓ PASSED

Testing --dry-run mode for hive command with user URL...
  hive --dry-run user URL: ✓ PASSED

Testing --dry-run mode for hive command with repo URL...
  hive --dry-run repo URL: ✓ PASSED

All tests PASSED! ✓

🤖 Generated with Claude Code

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #539
@konard konard self-assigned this Mar 14, 2026
@konard
Copy link
Copy Markdown
Contributor Author

konard commented Mar 30, 2026

🤖 AI Work Session Started

Starting automated work session at 2026-03-30T18:39:52.994Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

…539

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@konard konard changed the title [WIP] We need to make sure we test start-screen for --dry-run mode for both solve and hive commands fix: test start-screen for --dry-run mode for solve and hive commands (issue #539) Mar 30, 2026
@konard konard marked this pull request as ready for review March 30, 2026 18:46
@konard
Copy link
Copy Markdown
Contributor Author

konard commented Mar 30, 2026

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard marked this pull request as draft April 11, 2026 04:35
@konard
Copy link
Copy Markdown
Contributor Author

konard commented Apr 11, 2026

🤖 AI Work Session Started

Starting automated work session at 2026-04-11T04:35:03.959Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard marked this pull request as ready for review April 11, 2026 04:37
@konard
Copy link
Copy Markdown
Contributor Author

konard commented Apr 11, 2026

✅ Ready to merge

All requirements for issue #539 are satisfied:

  • Fix: src/start-screen.mjs uses the shared parseGitHubUrl from github.lib.mjs, accepting user/org URLs like https://github.com/konard (consistent with hive and solve commands)
  • Tests: tests/test-start-screen.mjs includes --dry-run tests for both solve and hive commands (including the exact failing case from the issue)
  • CI: .github/workflows/release.yml runs test-start-screen.mjs as a check step

All CI checks pass. PR has no merge conflicts.


Reviewed by AI work session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We need to make sure we test start-screen for --dry-run mode for both solve and hive commands

1 participant