resvg_render() (C wrapper function) does not crash on incorrect input#926
Open
geometer wants to merge 3 commits intolinebender:mainfrom
Open
resvg_render() (C wrapper function) does not crash on incorrect input#926geometer wants to merge 3 commits intolinebender:mainfrom
geometer wants to merge 3 commits intolinebender:mainfrom
Conversation
Collaborator
|
I think the right fix for this is to fix the crash in the Rust version instead? What file are you having problems with, and what is the backtrace? |
Collaborator
|
Catching panics is probably a good idea, but you are checking for And yes, we should also fix the cause of the crash, not just handling of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the library in our C++ project via C wrappers, we found that the app crashes if SVG data are incorrect. E.g, contain extra chars after closing the root
<svg>tag. The patch fixes that issue by catching a panic instead of throwing it into C++ code (where catching is impossible).