Draft
Conversation
nicoburns
force-pushed
the
misc-changes-for-initial-release
branch
3 times, most recently
from
37ac030 to
a74723b
Compare
| pub enum ImageFormat { | ||
| /// 32-bit RGBA with 8-bit channels. | ||
| Rgba8 = 0, | ||
| // NOTICE: If a new value is added, be sure to update the bytemuck CheckedBitPattern impl. |
Collaborator
There was a problem hiding this comment.
This is an indication that we would need that bytemuck stuff here as well.
Contributor
Author
There was a problem hiding this comment.
Ah yes, missed this because it's in a separate file in peniko
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
misc-changes-for-initial-release
branch
3 times, most recently
from
711bd55 to
d52b103
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
misc-changes-for-initial-release
branch
from
d52b103 to
050b764
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
Collaborator
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
I don't think the copyright changes are correct ... and you left out the tests from the bytemuck support.
Member
|
My current thinking here is that this type actually still belongs in Peniko. See some of the reasons at #linebender > raw_resource_handle crate extraction from Peniko @ 💬. I think this is the consensus position at the moment. There's a lot more interesting discussion further down that thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
RawImageDatatype based onImageDatafrom Separate outImageBrushandImageBrushReffromImagepeniko#117