Skip to content

Landing Page#44

Merged
armansito merged 5 commits intomainfrom
landing-page
Jul 23, 2024
Merged

Landing Page#44
armansito merged 5 commits intomainfrom
landing-page

Conversation

@armansito
Copy link
Copy Markdown
Contributor

Bare bones homepage for the paper. Contains links to arXiv, this GitHub repository, embedded YouTube video of the 40 second reel, and the abstract.

Some things to add in the short term:

  • A bit more detail about the code and how to find the shader code in Vello.
  • A natbib citation blurb
  • Embedded version of https://levien.com/tmp/beztoy/

@raphlinus
Copy link
Copy Markdown
Contributor

Definitely looks good as a start. I think the HTML file (and any other assets it links to, including the wasm for the interactive example) should be in a docs/ subdirectory, otherwise it mixes up serving source. I'm fine with this starting out as static HTML, and possibly going to an action to deploy later if we need it, but there's also a pretty good chance we won't.

Comment thread index.html
<link href="https://fonts.googleapis.com/css2?family=Material+Icons" rel="stylesheet">
<style>
body {
font-family: 'Lato', Verdana, Helvetica, sans-serif;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GF call to bring in Lato is missing, so this renders as Verdana on my system.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@armansito
Copy link
Copy Markdown
Contributor Author

I moved files relating to the landing page to landing_page/. I can rename that to docs/ too.

I also embedded beztoy with minor modifications. The description for the toy could use a bit more info (e.g. it doesn't explain the red error bar atm). I built the WASM locally (using raphlinus/raphlinus.github.io#100) and simply included the build output here.

@armansito armansito marked this pull request as ready for review July 22, 2024 23:05
Copy link
Copy Markdown
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree it might be nice to have more description (like the error bar), but I think we can start here.

There's probably a way to use a folder name other than /docs, but I can't immediately figure it out. The subdirectories that are there now (flatten etc) don't show in the config screen. So I recommend we change the subdirectory to that.

I also like the Lato font well enough :)

- Moved the page sources to docs/.
- Bundled a release build of the beztoy JS and WASM.
- Fixed an issue in the interactive toy that caused a control point
  to be permanently lost when dragged out of view.
@armansito armansito merged commit a01be86 into main Jul 23, 2024
@armansito armansito deleted the landing-page branch July 23, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants