Add required: true for setRichMenuImage to fix sdk parameters#123
Open
Add required: true for setRichMenuImage to fix sdk parameters#123
Conversation
NODEJSYou can check generated code in nodejs |
PHPYou can check generated code in php |
JAVAYou can check generated code in java |
GOYou can check generated code in go |
PYTHONYou can check generated code in python |
RUBYYou can check generated code in ruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While upgrading the Node.js SDK to TypeScript v6, I noticed that the
binaryparameter forsetRichMenuImageis incorrectly marked as optional. You can't set a rich menu image without the image data, so it should never be optional. This change corrects this.Looking at the generated code, this issue affects all SDKs except for Go. While the real-world impact is likely minor, since users would quickly realize the image is necessary and wouldn't keep sending requests without it. Anyway the API definition in the YAML should be accurate. Let's ensure it reflects the correct, required state.
I also checked other APIs, but only the
setRichMenuImageforgets this, so we don't have to modify others as of now.