Skip to content

Highlighting improvements #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankreedX wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Highlighting improvements #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1fdf4
improved Saved highlight text box behavior for smaller spaces and set…
FrankreedX Jun 24, 2024
5c2207d
disables highlight mode by default, and handled the case where the le…
FrankreedX Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/unclutter/source/common/featureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const defaultFeatureFlags = {
[isDevelopmentFeatureFlag]: false,
[enableSocialCountsFeatureFlag]: true,

[enableAnnotationsFeatureFlag]: true,
[enableAnnotationsFeatureFlag]: false,
[enableSocialCommentsFeatureFlag]: true,

[submittedFeedbackFlag]: false,
Expand Down
4 changes: 2 additions & 2 deletions apps/unclutter/source/overlay/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
position: absolute !important;
top: 8px !important;
left: calc((100vw - var(--lindy-pagewidth)) / 2 + var(--lindy-pagewidth) - 4px) !important;
width: calc((100vw - var(--lindy-pagewidth)) / 2 - 8px - 4px) !important;
width: calc((100vw - var(--lindy-pagewidth)) / 2 - 8px - 34px) !important;
height: calc(100% - 8px) !important;
user-select: none !important;
contain: strict !important;
Expand Down Expand Up @@ -279,7 +279,7 @@
}
#lindy-annotations-bar {
left: calc(var(--lindy-pagewidth) + 10px + 5px) !important;
width: calc(100vw - (var(--lindy-pagewidth) + 10px + 5px) - 15px) !important;
width: calc(100vw - (var(--lindy-pagewidth) + 10px + 5px) - 46px) !important;
}
.lindy-page-settings-pageadjacent {
left: calc(var(--lindy-pagewidth) + 10px + 0px) !important;
Expand Down
2 changes: 1 addition & 1 deletion apps/unclutter/source/overlay/ui/Controls/PrivateNotesControl.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
export let smartHighlightsProxy: SmartHighlightsProxy;
export let overlayModifier: OverlayManager;

let privateNotesEnabled: boolean = true;
let privateNotesEnabled: boolean = false;
getFeatureFlag(enableAnnotationsFeatureFlag).then((defaultEnabled) => {
privateNotesEnabled = defaultEnabled;
});
Expand Down
11 changes: 6 additions & 5 deletions apps/unclutter/source/sidebar/components/AnnotationDraft.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default function AnnotationDraft({
return (
<div
className={clsx(
`annotation annotation-draft relative rounded-l-sm rounded-r-md p-2 px-3 text-sm shadow`,
`annotation annotation-draft relative rounded-l-sm rounded-r-md p-2 px-3 text-sm shadow flex flex-wrap`,
annotation.focused && "focused",
className
)}
Expand All @@ -84,11 +84,12 @@ export default function AnnotationDraft({
// @ts-ignore
"--dark-border-color": colorDark || color,
maxHeight: heightLimitPx,
minWidth: 110,
}}
// ref={ref}
>
<TextareaAutosize
className="w-full select-none resize-none overflow-hidden bg-transparent align-top outline-none placeholder:select-none placeholder:text-stone-400 dark:placeholder:text-stone-600"
className="select-none resize-none overflow-hidden bg-transparent align-top outline-none placeholder:select-none placeholder:text-stone-400 dark:placeholder:text-stone-600 grow"
placeholder={
userInfo?.aiEnabled
? annotation.tags.map((t) => `#${t}`).join(" ")
Expand Down Expand Up @@ -116,9 +117,9 @@ export default function AnnotationDraft({
{isFetching ? (
<div className="loader absolute right-3 top-[9px] h-4 w-4" />
) : (
<div className="animate-fadein absolute top-[1px] right-1 flex gap-0 text-stone-400 dark:text-stone-600">
<div className="animate-fadein flex gap-4 text-stone-400 dark:text-stone-600">
<svg
className="annotation-button h-8 cursor-pointer p-2"
className="annotation-button h-4 cursor-pointer"
viewBox="0 0 512 512"
onMouseDown={(e) => e.preventDefault()}
onClick={() => copyTextToClipboard(`"${annotation.quote_text}"`)}
Expand All @@ -129,7 +130,7 @@ export default function AnnotationDraft({
/>
</svg>
<svg
className="annotation-button h-8 cursor-pointer p-2"
className="annotation-button h-4 cursor-pointer"
viewBox="0 0 448 512"
onMouseDown={(e) => e.preventDefault()}
onClick={() => deleteAnnotation(userInfo, annotation)}
Expand Down