-
Notifications
You must be signed in to change notification settings - Fork 11
Francesco Wild MrQ Test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElWildo
wants to merge
15
commits into
lindar-open:main
Choose a base branch
from
ElWildo:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add style import in SymbolView - Add style for symbolView Content and symbolView Cards - Add style import in SymbolGrid - Add style for symbolView Cards
- Extrat trend element and make it a component - Add Trend Component to header for the card - Add style for the trend icon - Update card header style - Fix file name to match naming convention
- Add industry and cap marked list element in SymbolCard
- Add formatter to Symbol Card - Update monetary values to be formatted - Add style for the price row
- Update SymbolsView structure - Update SymbolsView style
- Update Fromatted Price to display - for empty price values - Update SymbolCard to display - for empty pricevalues
- Add show card info state to card grid - Add card info view props to symbol card and use it to make extra info conditional
- Add conditional box shadow - Add conditional growing/shrinking animation
- Add shake animation - Add previous value hook
- Add shake animation - Add previous value hook
- Add wait for fetchPriceHistory to handle the race condition
- Add media query for mobile
- Update glow animation style - Move glow state managment to symbol card - Update buse previous hook
- Add action to reducer for active simbol - Update selected symbol state to be a redux state - Update SymbolCard to work with the new selected Active symbol state - Update fix race condition
- Add card deselection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 - Update card grid style
#2 - Update card header
#3 - Update card Item List
#4 - Format Money Values
#5 - Format Card Container
#6 - Implement more info functionality
#7 - Implement animation on interaction
#8 - Shake Animation
#9 - Add Glow
#10 - Fix race condition
#11 - Make the container responsive
#12 - Fix glow animation
#13 - Ensure card selected permanence
#14 - Fix card selection