Skip to content

Conversation

@ElWildo
Copy link

@ElWildo ElWildo commented Oct 24, 2024

#1 - Update card grid style

  • Add style import in SymbolView
  • Add style for symbolView Content and symbolView Cards
  • Add style import in SymbolGrid
  • Add style for symbolView Cards

#2 - Update card header

  • Extract trend element and make it a component
  • Add Trend Component to header for the card
  • Add style for the trend icon
  • Update card header style

#3 - Update card Item List

  • Add industry and cap marked list element in SymbolCard

#4 - Format Money Values

  • Add formatter to Symbol Card
  • Update monetary values to be formatted
  • Add style for the price row

#5 - Format Card Container

  • Update SymbolsView structure
  • Update SymbolsView style
  • Update Fromatted Price to display - for empty price values
  • Update SymbolCard to display - for empty pricevalues

#6 - Implement more info functionality

  • Add show card info state to card grid
  • Add card info view props to symbol card and use it to make extra info conditional

#7 - Implement animation on interaction

  • Add conditional box shadow
  • Add conditional growing/shrinking animation

#8 - Shake Animation

  • Add shake animation
  • Add previous value hook

#9 - Add Glow

  • Add state for glow "direction"

#10 - Fix race condition

  • Add wait for fetchPriceHistory to handle the race condition

#11 - Make the container responsive

  • Add media query for mobile

#12 - Fix glow animation

  • Update glow animation style
  • Move glow state management to symbol card
  • Update buse previous hook

#13 - Ensure card selected permanence

  • Add action to reducer for active symbol
  • Update selected symbol state to be a redux state
  • Update SymbolCard to work with the new selected Active symbol state
  • Update fix race condition

#14 - Fix card selection

  • Add card deselection

elWildo added 15 commits October 23, 2024 11:32
- Add style import in SymbolView
- Add style for symbolView Content and symbolView Cards
- Add style import in SymbolGrid
- Add style for symbolView Cards
- Extrat trend element and make it a component
- Add Trend Component to header for the card
- Add style for the trend icon
- Update card header style
- Fix file name to match naming convention
- Add industry and cap marked list element in SymbolCard
- Add formatter to Symbol Card
- Update monetary values to be formatted
- Add style for the price row
- Update SymbolsView structure
- Update SymbolsView style
- Update Fromatted Price to display - for empty price values
- Update SymbolCard to display - for empty pricevalues
- Add show card info state to card grid
- Add  card info view props to symbol card and use it to make extra info conditional
- Add conditional box shadow
- Add conditional growing/shrinking animation
- Add shake animation
- Add previous value hook
- Add shake animation
- Add previous value hook
- Add wait for fetchPriceHistory to handle the race condition
- Add media query for mobile
- Update glow animation style
- Move glow state managment to symbol card
- Update buse previous hook
- Add action to reducer for active simbol
- Update selected symbol state to be a redux state
- Update SymbolCard to work with the new selected Active symbol state
- Update fix race condition
- Add card deselection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant