Skip to content

Adding update and delete methods #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AcousticRand wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adding update and delete methods #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e89f5af
Adding update and delete methods
Apr 30, 2015
ed21469
Adding filters to repos list
May 7, 2015
30dfffa
Adding the merge data for pull merge
May 12, 2015
904eef1
PR page limit up to 100 instead of default 30
Jul 14, 2015
5f6dbf7
Issues page limit up to 100 instead of default 30
Jul 14, 2015
d541ed7
Issues page limit up to 100 instead of default 30
Jul 14, 2015
7cba486
Issues page limit up to 100 instead of default 30
Jul 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/api/pulls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ function Pulls(api)

//the api endpoint urls
this.urls = {
pulls : '/repos/%s/%s/pulls',
pulls : '/repos/%s/%s/pulls?per_page=100',
pullCreate : '/repos/%s/%s/pulls',
pull : '/repos/%s/%s/pulls/%s',
pullCommits : '/repos/%s/%s/pulls/%s/commits',
pullFiles : '/repos/%s/%s/pulls/%s/files',
Expand Down Expand Up @@ -64,7 +65,7 @@ Pulls.prototype.create = function(user, repo, data, callback)
user = user[0];
}
}
var url = util.format(this.urls.pulls, user, repo);
var url = util.format(this.urls.pullCreate, user, repo);
this.api.post(url, data, callback);
}

Expand Down Expand Up @@ -141,7 +142,7 @@ Pulls.prototype.isMerged = function(user, repo, number, callback)
this.api.get(url, null, callback);
}

Pulls.prototype.merge = function(user, repo, number, callback)
Pulls.prototype.merge = function(user, repo, number, data, callback)
{
if(typeof number == 'function'){
callback = number;
Expand All @@ -156,7 +157,7 @@ Pulls.prototype.merge = function(user, repo, number, callback)
}
}
var url = util.format(this.urls.merge, user, repo, number);
this.api.put(url, null, callback);
this.api.put(url, data, callback);
}

module.exports = Pulls;
24 changes: 19 additions & 5 deletions lib/api/repos/releases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,21 @@ function Releases(api)
//the api url endpoints
this.urls = {
releases : '/repos/%s/%s/releases',
latest : '/repos/%s/%s/releases/latest'
info : '/repos/%s/%s/releases/%s',
delete : '/repos/%s/%s/releases/%s',
update : '/repos/%s/%s/releases/%s'
}
}

Releases.prototype.list = function(user, repo, callback)
Releases.prototype.list = function(user, repo, filters, callback)
{
var url = util.format(this.urls.releases, user, repo);
this.api.get(url, null, callback);
this.api.get(url, filters, callback);
};

Releases.prototype.latest = function(user, repo, callback)
Releases.prototype.info = function(user, repo, tagname, callback)
{
var url = util.format(this.urls.latest, user, repo);
var url = util.format(this.urls.info, user, repo, tagname);
this.api.get(url, null, callback);
};

Expand All @@ -33,4 +35,16 @@ Releases.prototype.create = function(user, repo, data, callback)
this.api.post(url, data, callback);
};

Releases.prototype.update = function(user, repo, tagname, data, callback)
{
var url = util.format(this.urls.update, user, repo, tagname);
this.api.patch(url, data, callback);
};

Releases.prototype.delete = function(user, repo, tagname, callback)
{
var url = util.format(this.urls.delete, user, repo, tagname);
this.api.delete(url, null, callback);
};

module.exports = Releases;