cmake: raise an error if the library was not found#90
Merged
Conversation
The patch renames CMake variable `CMD_OUTPUT` to `LIB_PATH`, it makes code more clear.
The package with Clang runtime libraries may be missing on the host, in that case the CMake function `SetClangLibPath()` will return the library name even though it's not missing. The patch raises an error if the path returned by the compiler doesn't exist.
Buristan
approved these changes
Jun 4, 2026
Buristan
left a comment
Buristan
left a comment
Collaborator
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch set!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.