Align auth credential create contract#444
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-python studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
29cb640 to
892050e
Compare
892050e to
ba21425
Compare
Greptile SummaryThis PR updates the
Confidence Score: 4/5Safe to merge — all changes are documentation strings and no executable code is touched. The rewrite accurately models the new always-signed flow. One small grammatical typo ("an credential") made it through in three files (source + both bundles), but this has no functional impact. The typo in the Request-Id description propagates through openapi/paths/auth/auth_credentials.yaml, openapi.yaml, and mintlify/openapi.yaml — fixing it in the source and re-running make build will resolve all three at once.
|
| Filename | Overview |
|---|---|
| openapi/paths/auth/auth_credentials.yaml | Main source for the endpoint description rewrite — collapses the two-section (first credential / additional credential) flow into a single always-signed flow; contains one grammatical typo ("an credential"). |
| openapi/components/schemas/auth/AuthCredentialResponseOneOf.yaml | Removes the OAuth actionable hint ("call POST /auth/credentials/{id}/verify with a fresh OIDC token") — description is slightly less complete but otherwise correct. |
| openapi/components/schemas/auth/EmailOtpCredentialCreateRequestFields.yaml | Whitespace-only reformatting of the type field description — no semantic change. |
| openapi.yaml | Generated bundle reflecting the same changes as openapi/paths/auth/auth_credentials.yaml; contains the same "an credential" typo in the Request-Id header description. |
| mintlify/openapi.yaml | Mintlify bundle — identical changes to openapi.yaml, same "an credential" typo present. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
openapi/paths/auth/auth_credentials.yaml:49-50
Grammatical typo: "an credential" should be "a credential". This appears in the `Request-Id` header description and will be visible to API consumers in documentation.
```suggestion
challenge. Required on the signed retry when registering a
credential; must be paired with `Grid-Wallet-Signature`.
```
Reviews (1): Last reviewed commit: "Align auth credential create contract" | Re-trigger Greptile
| challenge. Required on the signed retry when registering an | ||
| additional credential; must be paired with `Grid-Wallet-Signature`. | ||
| credential; must be paired with `Grid-Wallet-Signature`. |
There was a problem hiding this comment.
Grammatical typo: "an credential" should be "a credential". This appears in the
Request-Id header description and will be visible to API consumers in documentation.
| challenge. Required on the signed retry when registering an | |
| additional credential; must be paired with `Grid-Wallet-Signature`. | |
| credential; must be paired with `Grid-Wallet-Signature`. | |
| challenge. Required on the signed retry when registering a | |
| credential; must be paired with `Grid-Wallet-Signature`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/paths/auth/auth_credentials.yaml
Line: 49-50
Comment:
Grammatical typo: "an credential" should be "a credential". This appears in the `Request-Id` header description and will be visible to API consumers in documentation.
```suggestion
challenge. Required on the signed retry when registering a
credential; must be paired with `Grid-Wallet-Signature`.
```
How can I resolve this? If you propose a fix, please make it concise.ba21425 to
330eaf5
Compare
330eaf5 to
14337ea
Compare

Uh oh!
There was an error while loading. Please reload this page.