-
Notifications
You must be signed in to change notification settings - Fork 1
Update pix account type to accept tax id #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryThis PR adds
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PixAccountInfo.yaml | Added taxId as a new required field with type string, description, and example. Missing trailing newline at end of file. |
| openapi.yaml | Bundled output file correctly generated from source with new taxId field in PixAccountInfo schema. |
| mintlify/openapi.yaml | Mintlify copy of bundled OpenAPI spec correctly mirrors root openapi.yaml with new taxId field. |
Sequence Diagram
sequenceDiagram
participant Client as API Client
participant Grid as Grid API
participant Schema as PixAccountInfo Schema
Client->>Grid: POST /external-accounts (PIX)
Grid->>Schema: Validate accountInfo
Note over Schema: Required fields:<br/>- accountType: PIX<br/>- pixKey<br/>- pixKeyType<br/>- taxId (NEW)
Schema-->>Grid: Validation result
Grid-->>Client: Response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
| taxId: | ||
| type: string | ||
| description: Tax ID of the account holder | ||
| example: '1234567890' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing trailing newline at end of file. Other schema files in this directory end with a newline.
| example: '1234567890' | |
| example: '1234567890' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PixAccountInfo.yaml
Line: 29:29
Comment:
**style:** Missing trailing newline at end of file. Other schema files in this directory end with a newline.
```suggestion
example: '1234567890'
```
How can I resolve this? If you propose a fix, please make it concise.
No description provided.