build: bump Go language to 1.25.11 and toolchain to 1.26.4#10875
build: bump Go language to 1.25.11 and toolchain to 1.26.4#10875ziggie1984 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update of the project's Go language and build toolchain versions. By standardizing these versions across the entire repository, the changes ensure consistency in development and CI environments, while also updating the installation guides to reflect the latest verified Go releases. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Go version across the repository. It bumps the minimum Go version from 1.25.10 to 1.25.11 in all go.mod files and documentation, adds the toolchain go1.26.4 directive to go.mod files, and updates Dockerfiles, CI configurations, and Makefiles to use Go 1.26.4. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
PR Severity: CRITICAL
High (3 files)
Medium (10 files)
Low (16 files)
AnalysisThis PR bumps the Go language version and toolchain across all lnd submodules (29 files total). The base severity is HIGH due to cert/go.mod (auth/security package) and sqldb/go.mod + sqldb/v2/go.mod (sqldb/* is HIGH). The severity is bumped to CRITICAL because the PR touches 29 files (exceeds the 20-file threshold, after excluding test files and auto-generated files). While the individual changes are mechanical (each go.mod updates the Go version directive), the breadth warrants expert review to ensure the toolchain upgrade does not introduce unexpected behavioral changes in security-sensitive packages like cert and sqldb. To override, add a severity-override-{critical,high,medium,low} label. |
This updates the Go language/minimum version and build toolchain pins separately:
go.modfiles now usego 1.25.11go.modfiles now declaretoolchain go1.26.4Verification:
git diff --checkGOTOOLCHAIN=local go mod edit -jsonGOTOOLCHAIN=local go mod edit -json1.25.10,go1.25.10,1.26.3, andgo1.26.3referencesNote:
make check-go-versioncurrently scans untracked local.context/worktree files in this checkout, so I verified tracked Docker/YAML version references directly instead.