Skip to content

build: bump Go language to 1.25.11 and toolchain to 1.26.4#10875

Open
ziggie1984 wants to merge 1 commit into
lightningnetwork:masterfrom
ziggie1984:bump-go-1.25.11-toolchain-1.26.4
Open

build: bump Go language to 1.25.11 and toolchain to 1.26.4#10875
ziggie1984 wants to merge 1 commit into
lightningnetwork:masterfrom
ziggie1984:bump-go-1.25.11-toolchain-1.26.4

Conversation

@ziggie1984
Copy link
Copy Markdown
Collaborator

This updates the Go language/minimum version and build toolchain pins separately:

  • all tracked go.mod files now use go 1.25.11
  • all tracked go.mod files now declare toolchain go1.26.4
  • release/toolchain pins move to Go 1.26.4 across Makefile, CI, Dockerfiles, golangci-lint config, and protobuf generation
  • install docs now reference Go 1.25.11 with official Linux amd64 and ARMv6 SHA256 checksums

Verification:

  • git diff --check
  • GOTOOLCHAIN=local go mod edit -json
  • parsed all nested module files with GOTOOLCHAIN=local go mod edit -json
  • checked tracked files for stale 1.25.10, go1.25.10, 1.26.3, and go1.26.3 references

Note: make check-go-version currently scans untracked local .context/ worktree files in this checkout, so I verified tracked Docker/YAML version references directly instead.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update of the project's Go language and build toolchain versions. By standardizing these versions across the entire repository, the changes ensure consistency in development and CI environments, while also updating the installation guides to reflect the latest verified Go releases.

Highlights

  • Go Version Update: Updated the minimum Go version to 1.25.11 across all tracked go.mod files.
  • Toolchain Pinning: Added explicit toolchain go1.26.4 declarations to all go.mod files.
  • Build Infrastructure: Synchronized build toolchain versions to 1.26.4 across Makefile, CI actions, Dockerfiles, and linting configurations.
  • Documentation: Updated installation documentation with the latest Go 1.25.11 checksums for Linux amd64 and ARMv6.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/govulncheck.yml
    • .github/workflows/main.yml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version across the repository. It bumps the minimum Go version from 1.25.10 to 1.25.11 in all go.mod files and documentation, adds the toolchain go1.26.4 directive to go.mod files, and updates Dockerfiles, CI configurations, and Makefiles to use Go 1.26.4. There are no review comments to address, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions github-actions Bot added the severity-critical Requires expert review - security/consensus critical label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR Severity: CRITICAL

Bumped from HIGH (>20 files rule) | 29 files | 104 lines changed

High (3 files)
  • cert/go.mod - cert/* is HIGH (auth/security package)
  • sqldb/go.mod - sqldb/* is HIGH
  • sqldb/v2/go.mod - sqldb/* is HIGH
Medium (10 files)
  • go.mod - root module
  • actor/go.mod - uncategorized package
  • clock/go.mod - uncategorized package
  • fn/go.mod - fn/* is MEDIUM
  • healthcheck/go.mod - uncategorized package
  • kvdb/go.mod - kvdb/* is MEDIUM
  • queue/go.mod - uncategorized package
  • ticker/go.mod - uncategorized package
  • tlv/go.mod - tlv/* is MEDIUM
  • tor/go.mod - tor/* is MEDIUM
Low (16 files)
  • .github/actions/setup-go/action.yml - CI/CD configuration
  • .github/workflows/govulncheck.yml - CI/CD configuration
  • .github/workflows/main.yml - CI/CD configuration
  • .github/workflows/release.yaml - CI/CD configuration
  • .golangci.yml - linting configuration
  • Dockerfile - docker/*
  • Makefile - make/*
  • dev.Dockerfile - docker/*
  • docker/btcd/Dockerfile - docker/*
  • docs/INSTALL.md - docs/*
  • lnrpc/Dockerfile - Dockerfile (build tooling)
  • lnrpc/gen_protos_docker.sh - scripts/*
  • make/builder.Dockerfile - make/*
  • tools/Dockerfile - tools/*
  • tools/go.mod - tools/*
  • tools/linters/go.mod - tools/*

Analysis

This PR bumps the Go language version and toolchain across all lnd submodules (29 files total). The base severity is HIGH due to cert/go.mod (auth/security package) and sqldb/go.mod + sqldb/v2/go.mod (sqldb/* is HIGH).

The severity is bumped to CRITICAL because the PR touches 29 files (exceeds the 20-file threshold, after excluding test files and auto-generated files).

While the individual changes are mechanical (each go.mod updates the Go version directive), the breadth warrants expert review to ensure the toolchain upgrade does not introduce unexpected behavioral changes in security-sensitive packages like cert and sqldb.


To override, add a severity-override-{critical,high,medium,low} label.
<!-- pr-severity-bot -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity-critical Requires expert review - security/consensus critical

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant