Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

@ViktorT-11 ViktorT-11 commented Dec 9, 2025

This PR mimics the PRs from lightningnetwork/lnd#10306 & lightninglabs/taproot-assets#1878, but for LNC, to combat the "no space left on device" issue we've seen in #121.

Note that there's one distinct difference from the tapd implementation. In this repo, we separate the cleanup of the android folder into a separate action. The reason for this separation is that we need to be able to control when the android folder is cleaned up, during the job, as some jobs will fail if the android folder is removed in the beginning of the job.

@ViktorT-11 ViktorT-11 force-pushed the 2025-12-add-CI-clenaup branch 3 times, most recently from 35ceaab to 384d456 Compare December 10, 2025 10:17
Define composite actions to remove large toolsets, unused packages,
Docker images, and caches from the GitHub runner, freeing up disk space
for builds.

Note that the content of the cleanup-space/actions.yaml file is copied
from the following `tapd` PR:
lightninglabs/taproot-assets#1878

There's one distinct difference from the `tapd` file. In this repo,
we separate the cleanup of the android folder into a separate action.
The reason for this separation is that we need to be able to control
when the android folder is cleaned up, during the job, as some jobs
will fail if the android folder is removed in the beginning of the job.

Not all of the targeted files when running the script, should ever
have been used when building the binaries for LNC, but we keep the
script consistent between the repos for simplicity.
Update workflows to use the new `cleanup-space` composite action for
clearing runner disk space.

Note that in the "build package and wasm" job, the cleanup of the
android build folder is done after the rest of the step is completed, as
the contents of the folder are needed during the "android compile" step.
@ViktorT-11 ViktorT-11 force-pushed the 2025-12-add-CI-clenaup branch 2 times, most recently from 58857b4 to 4bff749 Compare December 10, 2025 11:31
@ViktorT-11 ViktorT-11 requested a review from jamaljsr December 10, 2025 12:58
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ViktorT-11 ViktorT-11 merged commit 84c0ae8 into lightninglabs:master Dec 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants