Skip to content

Validate Esplora merkle proof against the block header's merkle root #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 1 commit into from
May 6, 2026
Merged

Validate Esplora merkle proof against the block header's merkle root #4596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lightning-transaction-sync/src/esplora.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,13 @@ impl<L: Logger> EsploraSyncClient<L> {

let mut matches = Vec::new();
let mut indexes = Vec::new();
let _ = merkle_block.txn.extract_matches(&mut matches, &mut indexes);
if indexes.len() != 1 || matches.len() != 1 || matches[0] != txid {
let computed_merkle_root =
merkle_block.txn.extract_matches(&mut matches, &mut indexes).ok();
if computed_merkle_root != Some(block_header.merkle_root)
|| indexes.len() != 1
|| matches.len() != 1
|| matches[0] != txid
{
log_error!(self.logger, "Retrieved Merkle block for txid {} doesn't match expectations. This should not happen. Please verify server integrity.", txid);
return Err(InternalError::Failed);
}
Expand Down
Loading