Include failure context in splice events#4514

Open

jkczyz wants to merge 18 commits intolightningdevkit:mainfrom

jkczyz:2026-03-splice-rbf-fail-event

Commits on Apr 28, 2026

Add NegotiationFailureReason to SpliceFailed event

jkczyz
and
claude
committed
f - mark NegotiationError and CounterpartyAborted as not retriable
jkczyz
committed

Commits on May 5, 2026

f - use odd TLV variant IDs for forward compatibility
jkczyz
committed
f - rephrase tx_abort message per spec rationale
jkczyz
committed
Add FundingContribution to SpliceFailed event

jkczyz
and
claude
committed
f - note that contributed inputs/outputs exclude prior rounds
jkczyz
committed
f - split RBF helper into amend default + at-feerate variant
jkczyz
committed
Emit DiscardFunding before SpliceFailed

jkczyz
and
claude
committed
Rename SplicePending and SpliceFailed events

jkczyz
and
claude
committed
Simplify contribution pop in reset_pending_splice_state

jkczyz
and
claude
committed
Fix output filtering in into_unique_contributions

jkczyz
and
claude
committed
Derive SpliceFundingFailed inputs from FundingContribution

jkczyz
and
claude
committed
Remove unused NegotiationError and contributed_inputs_and_outputs methods

jkczyz
and
claude
committed
Add pending changelog for splice negotiation event changes

jkczyz
and
claude
committed
Check can_initiate_rbf in stfu handler before sending tx_init_rbf

jkczyz
and
claude
committed
f - inline fresh selection in stfu_after_splice_locked test
jkczyz
committed
Derive DiscardFunding inputs and outputs from contributions on promotion

jkczyz
and
claude
committed
f - inline fresh selection in discard_unique_contribution test
jkczyz
committed