Hook up ChannelConfig in open channel endpoint & add to cli #81
+149
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were available on the server side but not in the cli
|
👋 I see @wpaulino was un-assigned. |
Collaborator
Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now? |
Collaborator
Author
|
I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends