Add ldk-server-mcp crate scaffolding for MCP gateway#202
Closed
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Add ldk-server-mcp crate scaffolding for MCP gateway#202vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
ldk-server-mcp crate scaffolding for MCP gateway#202vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
v1 scaffolding for an HTTPS gateway that will expose the LDK Server gRPC API as an MCP (Model Context Protocol) server, plus a small admin web UI for minting scoped auth tokens to plug into Claude Desktop / Claude Code. This PR adds the foundational pieces only: - New `ldk-server-mcp` workspace crate with a TOML config, an `axum`-based HTTPS listener (HTTP/1.1 + HTTP/2 via `hyper-util`'s auto builder), and a `/healthz` endpoint - Self-signed TLS cert auto-generation in `storage_dir`, mirroring the daemon's pattern in `ldk-server/src/util/tls.rs` (the daemon code is unchanged; the v2 plan extracts the shared bits into a util crate) - A `DaemonClient` wrapper around `ldk-server-client` that loads the daemon's `api_key` and TLS cert from disk and verifies connectivity on boot via `GetNodeInfo` - `GatewayLogger` matching the daemon's `ServerLogger` style so operators see consistent log output across the two processes - Sample config in `contrib/ldk-server-mcp-config.toml` and a crate-level `README.md` - Brainstorm doc at `docs/brainstorms/2026-05-07-ldk-server-mcp.md` capturing the full v1 spec and the suggested PR breakdown for the rest of the work (sqlite token store, web UI, MCP tool layer over the ~40 RPCs, `SubscribeEvents` -> MCP notifications fan-out, Connect-to-Claude UX) The daemon is unmodified. 14 unit tests cover config parsing, scheme stripping, log-level validation, unknown-field rejection, the cert generate/load roundtrip, and the `/healthz` route. `cargo fmt`, `cargo clippy --all-targets -- -D warnings`, `cargo test`, `cargo check --release`, and `cargo doc --release` all pass for the new crate. This change was developed with Claude Code assistance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
I've assigned @wpaulino as a reviewer! |
Contributor
Author
|
Ah sorry! i open the PR on the wrong repository.
Yes but this is an PoC over the Https transport layer and not only stdio See https://modelcontextprotocol.io/specification/2025-03-26/basic/transports but this is not ready to be proposed yet, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1 scaffolding for a new
ldk-server-mcpworkspace crate — an HTTPS gateway that will eventually expose the LDK Server gRPC API as an MCP (Model Context Protocol) server, plus a small admin web UI for minting scoped auth tokens to plug into Claude Desktop / Claude Code.This PR is the foundational layer only. The daemon is unmodified.
ldk-server-mcpworkspace crate: TOML config +axumHTTPS listener (HTTP/1.1 + HTTP/2 viahyper-utilauto builder) +/healthzldk-server/src/util/tls.rs. Copied (not extracted into a shared util crate) to keep this PR scoped — the brainstorm doc flags the refactor as a v2 deferred item.DaemonClientwrapper aroundldk-server-clientthat loads the daemon'sapi_keyand TLS cert from disk and verifies connectivity on boot viaGetNodeInfo.GatewayLoggermatching the daemon'sServerLoggerso operators see consistent log output across the two processes.contrib/ldk-server-mcp-config.tomland crate-levelREADME.md.docs/brainstorms/2026-05-07-ldk-server-mcp.mdcapturing the full v1 spec and the PR breakdown for follow-ups (sqlite token store, web UI, MCP tool layer over the ~40 RPCs,SubscribeEvents-> MCP notifications fan-out, Connect-to-Claude UX).Architecture
ldk-server-mcpis a separate process and a separate workspace crate fromldk-server. It calls the daemon over its existing gRPC + TLS interface usingldk-server-client. Token storage and scope enforcement live entirely in the gateway in v1; promoting them into the daemon is the v2 path described in the brainstorm.New dependencies
axum 0.7(default features off;json,tokio)hyper 1server featureshttp1,http2hyper-util 0.1featurestokio,service,server-auto,http1,http2tower 0.5(dev-only, forServiceExt::oneshotin tests)Everything else is reused from the workspace (
tokio,tokio-rustls,ring,serde,toml,clap,log,chrono,hex-conservative,base64,getrandom,ldk-server-client,ldk-server-grpc).Test plan
cargo fmt --all -- --checkcleancargo clippy -p ldk-server-mcp --all-targets -- -D warningscleancargo test -p ldk-server-mcp— 14 tests pass (config parse / unknown-field reject / log-level validate / TLS generate-and-load roundtrip //healthzreturns 200 / unknown path returns 404)cargo check --release -p ldk-server-mcpcleancargo doc --release -p ldk-server-mcp --no-depscleancurl -k https://127.0.0.1:3537/healthz->ok) — recommended before mergeNotes for review
util/tls.rsis duplicated rather than shared. The brainstorm doc flags extracting it into aldk-server-utilcrate as a v2 follow-up — keeping this PR to one new crate keeps the diff reviewable. ALPN here is["h2", "http/1.1"](vs. the daemon's["h2"]) so browsers reach the future UI.debug!(noterror!) — port-scanning is normal in the threat model and we don't want to spam the log on each scan./api/*UI endpoints are deliberately not in this PR — they land in PR2 of the breakdown in the brainstorm doc.This change was developed with Claude Code assistance.