Skip to content

Make review reminders opt-in #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joostjager wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make review reminders opt-in #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
github_bot = GitHubBot(
token=os.environ.get("GITHUB_TOKEN"),
webhook_secret=os.environ.get("WEBHOOK_SECRET"),
db=db
db=db,
review_reminders_enabled=os.environ.get("ENABLE_REVIEW_REMINDERS", "").lower() == "true"
)
logger.info("init'd github bot...")

Expand Down
8 changes: 6 additions & 2 deletions github_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@
IGNORED_REVIEWERS = ['graphite-app[bot]']

class GitHubBot:
def __init__(self, token, webhook_secret, db):
def __init__(self, token, webhook_secret, db, review_reminders_enabled=False):
self.token = token
self.webhook_secret = webhook_secret.encode()
self.db = db
self.review_reminders_enabled = review_reminders_enabled
self.logger = logging.getLogger(__name__)
self.headers = {
'Authorization': f'token {token}',
Expand Down Expand Up @@ -562,7 +563,7 @@ def auto_assign_reviewers(self, pr_record):

def check_and_send_reminders(self):
"""Check for PRs needing review reminders and auto-assign reviewers."""
self.logger.info("Checking for PRs needing review reminders...")
self.logger.info("Checking for PRs needing reviewer assignment/reminders...")

current_time = datetime.utcnow()
reviewer_threshold = current_time - timedelta(minutes=10)
Expand All @@ -580,6 +581,9 @@ def check_and_send_reminders(self):
for pr in prs_needing_assignment:
self.auto_assign_reviewers(pr)

if not self.review_reminders_enabled:
return

# Nag reviewers, but only on weekdays
now = datetime.utcnow()
if now.weekday() < 4 or (now.weekday() == 5 and now.hour < 17):
Expand Down