Feature(v3) refactored zIndexing #669
Open
+288
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterlucas
reviewed
Dec 8, 2025
Contributor
wouterlucas
left a comment
wouterlucas
left a comment
There was a problem hiding this comment.
How are we mixing children that have a zIndex value and ones that do not (thus are null)?
Are we doing sorted first, unsorted after? Assuming all unsorted are below the sorted ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should reduce the zIndexing strain we have upon node creation. Especially when using either or the same zIndex values in one parent node.
To do: