Merge dev into v2/update#564
Merged
michielvandergeest merged 34 commits intolightning-js:v2/updatefrom Jan 7, 2026
Merged
Conversation
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
…in-translate-scope-regex fix(generator): rewrite plugin helpers in :for loop effects
…cific custom plugin type definition
…ctivity added reactivity support to regular shaders
…type-def feat: expose ComponentCustomProperties as a module-augmentation extension point
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
…e built-in plugins
sending empty mapping from reactivity guard plugin so that vite transform hook does not log an warning for not sending map when build is configured to send sourcemap. next vite plugin pre-compiler will takecare of creating correct sourcemap for components Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
…rove-sprite-tests test(sprite): add tests for texture reuse, mapping, and missing frames
…e-map-generation Source Map Generation
…ent-custom-properties-and-plugins feat(types): add ComponentCustomProperties augmentation point and typ…
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Handled sourcemap generation changes in prepublish
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
michielvandergeest
requested changes
Jan 5, 2026
Collaborator
michielvandergeest
left a comment
michielvandergeest
left a comment
There was a problem hiding this comment.
looks good - few minor comments
Collaborator
There was a problem hiding this comment.
this file should probably be deleted
Comment on lines
+378
to
+397
| export interface LanguagePlugin { | ||
| translate(key: string, ...replacements: any[]): string | ||
| readonly language: string | ||
| set(language: string): void | ||
| translations(translationsObject: Record<string, unknown>): void | ||
| load(file: string): Promise<void> | ||
| } | ||
|
|
||
| export interface ThemePlugin { | ||
| get<T = unknown>(key: string): T | undefined | ||
| get<T>(key: string, fallback: T): T | ||
| set(theme: string): void | ||
| } | ||
|
|
||
| export interface StoragePlugin { | ||
| get<T = unknown>(key: string): T | null | ||
| set(key: string, value: unknown): boolean | ||
| remove(key: string): void | ||
| clear(): void | ||
| } |
Collaborator
There was a problem hiding this comment.
should these still be here actually? Maybe also they shouldn't exist in the current master version (since we've changed this to explicit imports).
@il-sairamg can you comment?
Contributor
There was a problem hiding this comment.
You're correct — these shouldn't be in index.d.ts anymore.
Collaborator
There was a problem hiding this comment.
remove this file?
…th implementations - Removed LanguagePlugin, ThemePlugin, StoragePlugin, and AppStatePlugin from index.d.ts - Moved each interface to its respective plugin .d.ts file - Updated src/plugins/index.d.ts to import from individual plugin files - Removes circular dependency pattern - Completes explicit imports migration from PR 555
fix(types): remove plugin interfaces from index.d.ts and co-locate wi…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.