fix(ai-review): gate Create-PR button on server-computed eligibility (GitHub + flags)#23668
Merged
joaoviana merged 1 commit intoMay 29, 2026
Conversation
This was referenced May 29, 2026
Merged
Contributor
Author
This was referenced May 29, 2026
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-23668 has been deployed. Preview environment endpoints are available at: |
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
598e162 to
df961e4
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
69a8f0f to
9a8078f
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
9a8078f to
9918d63
Compare
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
df961e4 to
6303b0d
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
9918d63 to
1c3325c
Compare
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
6303b0d to
256997b
Compare
Preview Environment🌐 URL: https://lightdash-preview-pr-23668.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
256997b to
e6dce05
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
1c3325c to
bfb5668
Compare
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
e6dce05 to
610015f
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
bfb5668 to
6179378
Compare
joaoviana
force-pushed
the
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
branch
from
610015f to
ff905f4
Compare
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
6179378 to
a216dda
Compare
Base automatically changed from
05-29-feat_ai-review_run_writeback_on_worker_with_live_progress_pr6_
to
main
May 29, 2026 17:17
joaoviana
force-pushed
the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
from
a216dda to
1544d83
Compare
joaoviana
deleted the
05-29-fix_ai-review_gate_create-pr_button_on_server-computed_eligibility_github_flags_
branch
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+254
to
+256
| } catch { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
The bare catch {} block silently swallows all errors from projectModel.get(). The backend rules require proper error handling and logging: errors should be logged (via Winston) and categorised using the appropriate error classes from errors.ts. At minimum, unexpected errors should be logged at warn/error level so they surface in monitoring.
Spotted by Graphite (based on custom rule: packages/backend rules)
Is this helpful? React 👍 or 👎 to let us know.
lightdash-bot
pushed a commit
that referenced
this pull request
May 29, 2026
# [0.3055.0](0.3054.0...0.3055.0) (2026-05-29) ### Bug Fixes * **ai-review:** gate Create-PR button on server-computed eligibility (GitHub + flags) ([#23668](#23668)) ([2ecae83](2ecae83)) * **ai-review:** writeback hardening — progress-write race + resilience ([#23669](#23669)) ([ae39718](ae39718)) ### Features * **ai-review:** review-queue UI — Create PR, dismiss, status + PR link ([#23666](#23666)) ([2866822](2866822)) * **ai-review:** run writeback on worker with live progress (PR6) ([#23667](#23667)) ([c991df5](c991df5))
Collaborator
|
🎉 This PR is included in version 0.3055.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 7/9 (fix). Server-computes a per-item
writebackEligible(semantic-layer and GitHub project and both flags on); the Create PR button keys off it instead of root-cause alone. Also fast-fails the engine flag before enqueue.Why server-side:
useProjects()doesn't expose the dbt connection type, so the frontend can't tell which projects are GitHub-connected.🤖 Generated with Claude Code