feat: issue solana to evm orders#44
Open
Asem-Abdelhady wants to merge 4 commits intofeature/v2-117-add-solana-wallet-connection-to-the-uifrom
Open
feat: issue solana to evm orders#44Asem-Abdelhady wants to merge 4 commits intofeature/v2-117-add-solana-wallet-connection-to-the-uifrom
Asem-Abdelhady wants to merge 4 commits intofeature/v2-117-add-solana-wallet-connection-to-the-uifrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…stnet guard, timeout, as any, console.log, tests - Fix polygon public client: chain was incorrectly set to `base`, now `polygon` - Fix getSolanaConnection: throw on unsupported testnet instead of silently falling through to devnet - Remove solanaMainnet from chainList(true) and coinList(true) until mainnet programs are deployed - Raise CONFIRM_TIMEOUT_MS from 5 s to 30 s to reduce spurious retries on congested slots - Narrow `as any` casts in solanaEscrowLib.ts: typed anchorWallet with Transaction/VersionedTransaction generics, removed unnecessary `connection as any`, consolidated eslint-disable comments - Remove pre-existing console.log from intentFactory.ts compact signing path - Add tests/unit/solanaEscrowLib.test.ts: empty-inputs guard and Borsh encoding error wrapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solana/wallet-adapter-*openSolanaEscrowinsolanaEscrowLib.ts: Anchor-based Borsh encoding, PDA derivation, ATA resolution, andsendAndConfirmSolanaTxsubmissionsolanaTx.ts: resilient send-and-confirm loop with 30 s timeout, 1 retry on timeout, immediate throw on program errorsInputTokenModal— cannot mix chains in a single orderstore.solanaBalancesinIssueIntent.svelteidToToken()(EVM-only)containerToIntentrouting after JSON round-trip (bigint-as-string from DB)bigint-buffer(CVE-2025-3194) withbigint-buffer-fixed@^1.1.6via bunoverridesCode changes
src/lib/libraries/solanaEscrowLib.tssrc/lib/utils/solanaTx.tssrc/lib/utils/solana-wallet.svelte.tssrc/lib/libraries/intentFactory.tsopenSolanaEscrowsrc/lib/screens/IssueIntent.sveltesrc/lib/components/InputTokenModal.sveltesrc/lib/libraries/intentList.tssrc/lib/utils/intent.tsBigInt()coerce originChainId after DB round-tripsrc/lib/config.tspackage.json@coral-xyz/anchor;bigint-bufferCVE overrideTest plan
bun run test:unit— all 44 tests passInvalidAddressErroroutputs[0].oracle = 0xe48a6f95...Closes
Expected output
Screen.Recording.2026-04-08.at.1.00.29.PM.mov