feat: issue evm to solana orders#42
Open
Asem-Abdelhady wants to merge 11 commits intodevelopfrom
Open
Conversation
- add containerToIntent() helper in utils/intent.ts that wraps orderToIntent with automatic namespace detection (solana vs eip155) from OrderContainer - replace all orderToIntent(container) call sites with containerToIntent() - alias StandardOrderIntent as StandardEVMIntent in intentExecution.ts - add local idToToken() in intentList.ts (removed from @lifi/intent exports)
- Bump @lifi/intent from 0.0.3-alpha.1 to 0.0.4 - Add chainNamespace field to CoreToken in toCoreTokenContext - Fix containerToIntent: use 'in' narrowing for proper TypeScript overload resolution - Add StandardSolanaIntent guards in IntentFactory compact/escrow methods - Add StandardSolanaIntent guard in Solver.claim before finaliseIntent
Allows users to specify a custom EVM output recipient address, independent of the connected wallet. Defaults to the connected wallet when left blank.
…asem/V2-116/add-recipient-field
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… solana.ts unit tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Asem-Abdelhady
force-pushed
the
feature/v2-111-issue-evm-to-solana-orders
branch
from
785e394 to
ecacee2
Compare
Base automatically changed from
feature/v2-116-add-recipient-field-on-lintentorg
to
asem/V2-109/accommodate-intent.ts-solana-changes
May 6, 2026 12:36
Base automatically changed from
asem/V2-109/accommodate-intent.ts-solana-changes
to
develop
May 6, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solanaMainnet,solanaTestnet,solanaDevnetchain definitions via viemdefineChain, merged intochainMapandchainByIdSOLANA_MAINNET_CHAIN_ID,SOLANA_TESTNET_CHAIN_ID,SOLANA_DEVNET_CHAIN_IDfrom@lifi/intent— no more hardcoded numeric constantsSOLANA_CHAIN_IDSset,evmCoinList, andsolanaCoinListhelpers fromconfig.tscoinListgetCoin()address matching for 66-char bytes32 Solana token addressesallowedOutputSettlersviaSOLANA_OUTPUT_SETTLER_PDASfrom@lifi/intentTest Plan
bun test tests/unit/recipientField.test.ts— all 19 tests passLinear Ticket
Closes V2-111 — Issue EVM to Solana orders
Expected output
Screen.Recording.2026-04-07.at.6.01.42.PM.mov