Feat: SRV3 + CMv2 + CSMv3 proposed contracts and vote changes#927
Feat: SRV3 + CMv2 + CSMv3 proposed contracts and vote changes#927tamtamchik wants to merge 23 commits into
Conversation
…reaudit-deployment
chore: cm csm accounting, et factories on hoodi
There was a problem hiding this comment.
Pull request overview
Adds proposed SRv3-related contract addresses to the mainnet “Deployed contracts” documentation, referencing the core repo PR as the source of truth.
Changes:
- Added multiple
\[proposed]contract addresses (implementations and new components) under Core Protocol. - Added
\[proposed]entries under Oracle Contracts for AccountingOracle and ValidatorsExitBusOracle. - Extended the list with additional SRv3 components (e.g., gateways, consolidation contracts, temporary admin).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d854189 to
f7f3dc9
Compare
…dresses docs: update hoodi module addresses
…fix1 Fix/srv3 proposed contracts fix1
lemonjelly27
left a comment
There was a problem hiding this comment.
Review scope so far (hoodi.md only — index.md to follow):
✅ Link-text/URL pairs checked, no mismatches.
⏳ The entries flagged inline don't appear in any hoodi proposal calldata
Could you attach deployment proof for these?
|
@lemonjelly27, regarding contacts addresses review you can additionally use JSON files with all artefacts. For core repo addresses: Cheers! 🙌 |
lemonjelly27
left a comment
There was a problem hiding this comment.
Mainnet (index.md) review complete.
✅ All link-text/URL pairs on added lines checked - no mismatches.
✅ All new contract addresses verified against the attached source-of-truth PRs. No discrepancies found.
⏳ One gap: I could not find these three addresses in any of the four attached PRs:
- Upgrade Config:
0xf94e7A95C559728AcA33bFa7136Ea5De40B0338E - Upgrade Template:
0xD92b6303Ba39297Cb69a3a17A88b47586A6af14C - Upgrade Vote Script:
0xE6530830A2cf90773cB232748b2c674c27b6E0CA
Could you add the source that covers them to the PR description?
Cosmetic, non-blocking: three addresses are lowercase rather than checksummed. Suggesting normalizing for consistency with the rest of the page.
lemonjelly27
left a comment
There was a problem hiding this comment.
Approving the PR. Thanks everyone for the quick follow-ups and for helping close the verification gaps so promptly.
Please, go through these steps before you request a review:
📝 Describe your changes
🔎 Attach a source of truth or evidence that allows reviewers to confirm the changes independently