Skip to content

Feat: SRV3 + CMv2 + CSMv3 proposed contracts and vote changes#927

Open
tamtamchik wants to merge 23 commits into
mainfrom
feat/srv3-proposed-contracts
Open

Feat: SRV3 + CMv2 + CSMv3 proposed contracts and vote changes#927
tamtamchik wants to merge 23 commits into
mainfrom
feat/srv3-proposed-contracts

Conversation

@tamtamchik

@tamtamchik tamtamchik commented Jul 1, 2026

Copy link
Copy Markdown
Member

Please, go through these steps before you request a review:

📝 Describe your changes

  1. New contracts for SRv3 deployment
  2. New contracts for CSMv3 deployment
  3. New contracts for CMv2 deployment
  4. New contracts for EasyTrack factories
  5. Upgrade contracts (vote)

🔎 Attach a source of truth or evidence that allows reviewers to confirm the changes independently

  1. feat: srv3 deployment core#1900
  2. CM v2 deployment artifacts on mainnet staking-modules#849
  3. Upgrade mainnet CSM staking-modules#842
  4. chore: CSMv3 and CMv2 factories deploy easy-track#125
  5. feat: srv3 deployment core#1912

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds proposed SRv3-related contract addresses to the mainnet “Deployed contracts” documentation, referencing the core repo PR as the source of truth.

Changes:

  • Added multiple \[proposed] contract addresses (implementations and new components) under Core Protocol.
  • Added \[proposed] entries under Oracle Contracts for AccountingOracle and ValidatorsExitBusOracle.
  • Extended the list with additional SRv3 components (e.g., gateways, consolidation contracts, temporary admin).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
@tamtamchik tamtamchik force-pushed the feat/srv3-proposed-contracts branch from d854189 to f7f3dc9 Compare July 1, 2026 17:12
@dgusakov dgusakov changed the title Feat: SRV3 proposed contracts Feat: SRV3 + CMv2 + CSMv3 proposed contracts and vote changes Jul 3, 2026
krogla
krogla previously approved these changes Jul 3, 2026

@krogla krogla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/deployed-contracts/index.md Outdated
mkurayan
mkurayan previously approved these changes Jul 7, 2026
mkurayan
mkurayan previously approved these changes Jul 7, 2026
dgusakov
dgusakov previously approved these changes Jul 8, 2026
krogla
krogla previously approved these changes Jul 8, 2026

@krogla krogla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TheDZhon TheDZhon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread docs/deployed-contracts/index.md Outdated
@mkurayan mkurayan dismissed stale reviews from krogla and dgusakov via c45b74c July 8, 2026 14:51
TheDZhon
TheDZhon previously approved these changes Jul 8, 2026

@TheDZhon TheDZhon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@lemonjelly27 lemonjelly27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review scope so far (hoodi.md only — index.md to follow):

✅ Link-text/URL pairs checked, no mismatches.
⏳ The entries flagged inline don't appear in any hoodi proposal calldata

Could you attach deployment proof for these?

Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
Comment thread docs/deployed-contracts/hoodi.md
@mkurayan

Copy link
Copy Markdown
Contributor

@lemonjelly27, regarding contacts addresses review you can additionally use JSON files with all artefacts.

For core repo addresses:
hoodi: https://github.com/lidofinance/core/blob/develop/deployed-hoodi.json
mainnet: https://github.com/lidofinance/core/blob/develop/deployed-mainnet.json

Cheers! 🙌

@lemonjelly27 lemonjelly27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainnet (index.md) review complete.

✅ All link-text/URL pairs on added lines checked - no mismatches.
✅ All new contract addresses verified against the attached source-of-truth PRs. No discrepancies found.

⏳ One gap: I could not find these three addresses in any of the four attached PRs:

  • Upgrade Config: 0xf94e7A95C559728AcA33bFa7136Ea5De40B0338E
  • Upgrade Template: 0xD92b6303Ba39297Cb69a3a17A88b47586A6af14C
  • Upgrade Vote Script: 0xE6530830A2cf90773cB232748b2c674c27b6E0CA

Could you add the source that covers them to the PR description?

Cosmetic, non-blocking: three addresses are lowercase rather than checksummed. Suggesting normalizing for consistency with the rest of the page.

Comment thread docs/deployed-contracts/index.md
Comment thread docs/deployed-contracts/index.md
Comment thread docs/deployed-contracts/index.md
Comment thread docs/deployed-contracts/index.md

@lemonjelly27 lemonjelly27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR. Thanks everyone for the quick follow-ups and for helping close the verification gaps so promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.