Optimize compression of common opening moves#18
Open
ErdoganSeref wants to merge 9 commits intolichess-org:masterfrom
Open
Optimize compression of common opening moves#18ErdoganSeref wants to merge 9 commits intolichess-org:masterfrom
ErdoganSeref wants to merge 9 commits intolichess-org:masterfrom
Conversation
Add dependency to Trie data structure Implement longest common prefix search
Make encode and decode method non static
In contrast to the corresponding Rust implementation there is no need to convert the integer to a bit vector because the data structure responsible for writing bits to the buffer already supports integers.
…ible for encoding
Use simpler approach to guarantee correctness first
Remove test case related to old encoding format
Remove unused imports Replace wildcard import with specific imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented an additional optimization for compressing common opening moves.
The algorithm works by mapping common openings to integers. Then a game is prefix matched to find the longest common opening present in the mapping.