Fix BSScript::Object in v1.15.222 by reimplementing previously inlined member functions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just realized I forgot to reimplement the destructor, which I believe has also been inlined. After taking a look at it, I doubt I have the skill or knowledge to reimplement ~Object() correctly in the near future. It seems fine until the last function, and that has a large call tree that I'm having difficulty finding any sign of in 1.15.222. |
Contributor
|
Can you add a Also |
Move new Object member functions definitions into a .cpp file Add TODO for BSScript::~Object()
RunnerScrab
force-pushed
the
RunnerScrab_FixBSScriptObject
branch
from
c4ed02f to
d3e3b73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code I used for reference was from 1.14.74. If there are higher level synchronization primitives I should use instead, LMK, but I couldn't find any to use with Object::refCountAndHandleLock I thought would be compatible.
This also seems to fix (or make accessible again) at least a few uses of BSScript::Actor, namely passing it as an argument to a native bound function, and the GetPosition and GetAngle functions.
(The previous commit on the feature branch updates the Address Library IDs for the GetSource() of the Activation Event and BarterMenu events. It probably should be in a separate PR, but it's kind of a small change on its own and does fix those events, so I will leave that to your judgment.)